From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jianjun Wang <jianjun.wang@mediatek.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Ryder Lee <ryder.lee@mediatek.com>,
Rex-BC.Chen@mediatek.com, TingHan.Shen@mediatek.com,
Liju-clr.Chen@mediatek.com, Jian.Yang@mediatek.com
Subject: Re: [PATCH v3] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195
Date: Tue, 2 Aug 2022 11:04:50 +0200 [thread overview]
Message-ID: <3fdbac20-5ccd-7974-300e-2d78d0be048a@linaro.org> (raw)
In-Reply-To: <cd9518e3-9cb4-5165-af03-00e5300ab927@linaro.org>
On 02/08/2022 10:59, Krzysztof Kozlowski wrote:
>>
>> reg:
>> maxItems: 1
>> @@ -84,7 +91,9 @@ properties:
>> - const: tl_96m
>> - const: tl_32k
>> - const: peri_26m
>> - - const: top_133m
>> + - enum:
>> + - top_133m # for MT8192
>> + - peri_mem # for MT8188/MT8195
>
> This requires allOf:if:then restricting it further per variant.
I see Rob proposed that way, so skip this comment.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-02 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 11:37 [PATCH v3] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195 Jianjun Wang
2022-08-02 8:59 ` Krzysztof Kozlowski
2022-08-02 9:04 ` Krzysztof Kozlowski [this message]
2022-08-02 9:43 ` Jianjun Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fdbac20-5ccd-7974-300e-2d78d0be048a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Jian.Yang@mediatek.com \
--cc=Liju-clr.Chen@mediatek.com \
--cc=Rex-BC.Chen@mediatek.com \
--cc=TingHan.Shen@mediatek.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).