From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E165EC7EE23 for ; Sun, 4 Jun 2023 18:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231739AbjFDSFB (ORCPT ); Sun, 4 Jun 2023 14:05:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231167AbjFDSFA (ORCPT ); Sun, 4 Jun 2023 14:05:00 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83112BD for ; Sun, 4 Jun 2023 11:04:59 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-96fdc081cb3so594170966b.2 for ; Sun, 04 Jun 2023 11:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685901898; x=1688493898; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ihBL6TJ8C6mU92dx3ETVIyIXq8wWv0W19OQrtjTVS6E=; b=FI30/lnyqGkqjoM7lJFPYMooptVi/7DeeM1KS/E0KPhdJXv8U4Eow239gWj/7KQwc+ /V02myVs6yai/PTWZ4tQHmE+oXtxhX/cb4AVwYcQC4+6KvkTKclOH4chqPK78JOhhSjk O1bW0TsyxsAPdLAaE0FwspvFT84WXU2OEHSZkWrNXa4DolOdbGqinLMfbpGTLuNJgIk4 8Q+iGmfaMAuoLpO76CTFxPzJGtJ4VTmDGFIw5uVp9e41q0z56jjWnQNBf2Te8K/OKO+n hzjArDemAds0fl9w5QcqedUGh6NfUTl90unSsFR4mMr+Axl1lcDhJBrIXd3HWWrI7Vvj yqRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685901898; x=1688493898; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ihBL6TJ8C6mU92dx3ETVIyIXq8wWv0W19OQrtjTVS6E=; b=B351F6UGLGizyWPGGlVmEV3s5C42gtpXhQjT+L4RLpStaGmA8VwgPa7QbnGii805qt QOcusJXMoqs46vg7LZ6ABQYPktQaWshk722O/H7BUJJpY6fS2pX4uiv3747RzEDHZzXr EQoVP9JK6VPO2VCEW+g1PxUoEMlkKmbLY6WpftkYr+hoF4CjYi7XuFpwVUGVXC3ZHodv uW2voFtege8qRG7EqUrZvLc3WvCKp+glg2bp2EXsQ14waSehg5iWXfHdORM7yrJt3Tdv So9+PEXTHBgdBUsNMtwlll9cL5cdcpPQEpPQZLOQluUJ42GrsRXQS0qJgyQTyySfAQvv NzQw== X-Gm-Message-State: AC+VfDz8L7dVVoeEZj4Vr03mzgWDHpOq5ZeEbv0CpuKDoQEYcpThtLk5 jXUPXy4Hw1WyrP1kMr+rzzBZGA== X-Google-Smtp-Source: ACHHUZ4+vFM/nr8fGvYX+DNeO5lxMdAF0enwX9IrUSUB6khhTQ6PAinPxZOCuZMqppzelTPW9qs6IQ== X-Received: by 2002:a17:907:9444:b0:974:391f:ed7d with SMTP id dl4-20020a170907944400b00974391fed7dmr4950469ejc.49.1685901898018; Sun, 04 Jun 2023 11:04:58 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id c8-20020a170906924800b00977cc473b41sm1356087ejx.142.2023.06.04.11.04.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jun 2023 11:04:57 -0700 (PDT) Message-ID: <3fe03b31-0cab-82cf-cbdb-766fdf34c44d@linaro.org> Date: Sun, 4 Jun 2023 20:04:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v5 04/12] dt-bindings: display/msm: Add SM6350 MDSS Content-Language: en-US To: Konrad Dybcio , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Will Deacon , Robin Murphy , Joerg Roedel , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev References: <20230411-topic-straitlagoon_mdss-v5-0-998b4d2f7dd1@linaro.org> <20230411-topic-straitlagoon_mdss-v5-4-998b4d2f7dd1@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230411-topic-straitlagoon_mdss-v5-4-998b4d2f7dd1@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/05/2023 09:46, Konrad Dybcio wrote: > Document the SM6350 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 +++++++++++++++++++++ > 1 file changed, 214 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml > new file mode 100644 > index 000000000000..6674040d2172 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml > @@ -0,0 +1,214 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/qcom,sm6350-mdss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm SM6350 Display MDSS > + > +maintainers: > + - Krishna Manikandan > + > +description: > + SM6350 MSM Mobile Display Subsystem (MDSS), which encapsulates sub-blocks > + like DPU display controller, DSI and DP interfaces etc. > + > +$ref: /schemas/display/msm/mdss-common.yaml# > + > +properties: > + compatible: > + items: Drop items. It's just const. > + - const: qcom,sm6350-mdss > + > + clocks: > + items: > + - description: Display AHB clock from gcc > + - description: Display AXI clock from gcc > + - description: Display core clock > + > + clock-names: > + items: > + - const: iface > + - const: bus > + - const: core > + > + iommus: > + maxItems: 1 > + > + interconnects: > + maxItems: 2 > + > + interconnect-names: > + maxItems: 2 Are you sure you have two interconnects? Example is missing them. Best regards, Krzysztof