From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CCAC433F5 for ; Wed, 2 Mar 2022 16:26:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232978AbiCBQ1a (ORCPT ); Wed, 2 Mar 2022 11:27:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240206AbiCBQ11 (ORCPT ); Wed, 2 Mar 2022 11:27:27 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8D43CC51B for ; Wed, 2 Mar 2022 08:26:43 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id p9so3593763wra.12 for ; Wed, 02 Mar 2022 08:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=XjaeiEY8a1tH5c2j9KNmVI9SB++cezD6KFaef4Xjcac=; b=zP0BA6qB3rPhTnq8Fj9Z87v5Om3r3lpqiDAIoP2yPgV+O441mHTr7Ur1NOl002un1B CVZvsGx2tkNU6Uj24hNt0x2YU/ZVLnFBGj9cg7O8bGuozsHa888HLGJ6C88/M0XpnS4O umjN75al8ea5bXZ53+cG1qUxOZDEHfI1U7OC0nDYWYG/XoQfNi0tGXVP3IN/vngQi15O 6GwdlyVjx7Q0LE+q03Zv7WDqsXarq6VoZxG0DMKwtHOanwWAx1QYggVsqKYT2gobrI0A rXKq0rnmMVduqpklvtted93fzbsSmbHEhVzt2m8NAVbd0L5v336bhFvvNZVc4qdB5FyK +VGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XjaeiEY8a1tH5c2j9KNmVI9SB++cezD6KFaef4Xjcac=; b=Br8/fSxFO0SRCC5mj5UT1jXc5vSMDmjl0OFWAs8b9wHmOiEN9WRgnSVCTcIK4f/Dtq l0wnhMjfYaCAJRG9lf8AdW8TW2ff9R+lYc4BwWJb7fuUY3csIZLxGWI3Fe7HYjAzRQdy 8npQgd+xoPFck3aGZqXzgMQHhVubRvN9RTA/e6HTsHx2/Rfe22l6hHZpPaO1XB6lw/6C qkLSJOaLKL1wvPEop77WrNO3c3oLd9pWdpMGoRV5gnNVy0tXFPqjb7UoinnH7YWtdgA0 JEJl36M0v9LyTtFBDREV08TBm+upI43B6bnbXH4Vn/fDYxu21yTiGGB0JzzhANHYVpUz c+7A== X-Gm-Message-State: AOAM531wCDvsVSuXMnqhKTOXa0Bog0bUkNWbrMkHBKZ1uRWBhOT9sR8i Tfh9lB9kGIg4k4FfJYAEeffJ7w== X-Google-Smtp-Source: ABdhPJzKY+/eMiZPibbAsxw/NaB6uXT2sK3X5WA4cVQHSoWusKxMSFLA03cK79cL79Q1DUIlIf+R9A== X-Received: by 2002:adf:f849:0:b0:1ef:5d80:c68a with SMTP id d9-20020adff849000000b001ef5d80c68amr19686368wrq.280.1646238402267; Wed, 02 Mar 2022 08:26:42 -0800 (PST) Received: from ?IPV6:2a01:e34:ed2f:f020:b9e3:8853:bc0:bb98? ([2a01:e34:ed2f:f020:b9e3:8853:bc0:bb98]) by smtp.googlemail.com with ESMTPSA id i9-20020adffdc9000000b001f046861795sm1588244wrs.19.2022.03.02.08.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 08:26:41 -0800 (PST) Message-ID: <3ff11b85-249f-2f47-cbc4-41d2ab6d168f@linaro.org> Date: Wed, 2 Mar 2022 17:26:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v8 2/2] clocksource: Add Intel Keem Bay timer support Content-Language: en-US To: "Sanil, Shruthi" , "tglx@linutronix.de" , "robh+dt@kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Cc: "andriy.shevchenko@linux.intel.com" , "mgross@linux.intel.com" , "Thokala, Srikanth" , "Raja Subramanian, Lakshmi Bai" , "Sangannavar, Mallikarjunappa" References: <20220222095654.9097-1-shruthi.sanil@intel.com> <20220222095654.9097-3-shruthi.sanil@intel.com> <91653d8d-1dc6-0170-2c3c-1187b0bad899@linaro.org> <23f86de0-3869-ee22-812d-ba610bac48b3@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/03/2022 17:07, Sanil, Shruthi wrote: >> -----Original Message----- From: Daniel Lezcano >> Sent: Wednesday, March 2, 2022 3:54 PM >> To: Sanil, Shruthi ; tglx@linutronix.de; >> robh+dt@kernel.org; linux-kernel@vger.kernel.org; >> devicetree@vger.kernel.org Cc: andriy.shevchenko@linux.intel.com; >> mgross@linux.intel.com; Thokala, Srikanth >> ; Raja Subramanian, Lakshmi Bai >> ; Sangannavar, >> Mallikarjunappa Subject: >> Re: [PATCH v8 2/2] clocksource: Add Intel Keem Bay timer support >> >> On 02/03/2022 11:12, Sanil, Shruthi wrote: >> >> [ ... ] >> >>>>> + if (!(val & TIM_CONFIG_PRESCALER_ENABLE)) { + >>>>> pr_err("%pOF: Prescaler is not enabled\n", np); + ret = >>>>> -ENODEV; + } >>>> >>>> Why bail out instead of enabling the prescalar ? >>> >>> Because it is a secure register and it would be updated by the >>> bootloader. >> Should it be considered as a firmware bug ? > > No. This is a common driver across products in the series and > enablement of this bit depends on the project requirements. Hence to > be sure from driver, we added this check to avoid initialization of > the driver in the case where it cannot be functional. I'm not sure to get the meaning of 'project requirements' but (for my understanding) why not describe the timer in the DT for such projects? >> -- Linaro.org │ Open source software for >> ARM SoCs >> >> Follow Linaro: Facebook | >> Twitter | >> Blog -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog