From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EAC6C4332F for ; Wed, 19 Oct 2022 11:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231919AbiJSLse (ORCPT ); Wed, 19 Oct 2022 07:48:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231854AbiJSLsO (ORCPT ); Wed, 19 Oct 2022 07:48:14 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4117516911E for ; Wed, 19 Oct 2022 04:27:24 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id g7so22479471lfv.5 for ; Wed, 19 Oct 2022 04:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=nXFGzSS2/u4bVAOtY2OBuez9ms3I4wdkLTeUoseOY3A=; b=dAwR0NuwlhUCkeBGQ6sh1KnbolBlC0LAC8xBMz3KtBC/YA7DtkI/75dUzKhfABYoom 1F29QCCJDyyv+oypS5Q5HFIZOQNSuQKQ4piod2wBha4ZeUBgM48TzD5ThK0h0BkhezNU PPvBXURYF7ZhVtKZ2auhrbnW+kCQX9YH/YMA+3g38rm1DR6n5H2mVl0739mUr8a9cD9c lVv5PT/D3VkyWmo5RyY1K0fdMQsDmr3/bxK1O0JIEwJUhG4tu3D4c07HN5ZBm+EUvIjY k0fTnJ75ht8At1VXZANo36FPJ/BUUI7E4NEh3QjnekedsnJp64CKp4vs10F7ejxqNGoG 4jjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nXFGzSS2/u4bVAOtY2OBuez9ms3I4wdkLTeUoseOY3A=; b=2DCer5YwR9i2aGr69bhdON6Adsh9qNqw60dnBC+y8LyRL0yPFjcJQoZdzaTm1qchNa PdCV2tB2ql1Y1Og/z2ef2N4p5jvcboRgkcfSmzPxDIbZIaRz4Ya+K+PkjVYqVdUeIoVY G3qYbvUHLnZd4tw9rYYWp5MR6008cyF7Mcc65VWQ8+U4hmepm5mv6Nr/glF3mBlkb9YK 2d3rcO5hp6cjJorCvY+IT7dYXLCdTUHBx7J8DnK1Y9ThiECbMLUX/dDgA4y163xEIBMO 1w2XWzTCjBxoPyyqKZqsy6/diVgVn2PyGOpDkLfxB6alJmYo3ECTW3HYYp8F2iMmYvnf jWBQ== X-Gm-Message-State: ACrzQf15PoQN4pBFg0ydtwU5pDy/BD2VXN1kueFk6JI3Tq+3Sa+fLihb JGCKVvR7wQQzLZzpYjb/49Wnz56KlfjxWHvk X-Google-Smtp-Source: AMsMyM6R+x5K/qnLw6cpJ0EZKFwazhL6E5XYy0THkjOXdiu8+PRsamzUWkh2rEIb+FAD6dQLyr2RWQ== X-Received: by 2002:a05:6000:1568:b0:22e:6691:57aa with SMTP id 8-20020a056000156800b0022e669157aamr4569795wrz.708.1666177740730; Wed, 19 Oct 2022 04:09:00 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:b15b:4b56:592a:c397? ([2a01:e0a:982:cbb0:b15b:4b56:592a:c397]) by smtp.gmail.com with ESMTPSA id e26-20020a05600c4b9a00b003a5537bb2besm15694485wmp.25.2022.10.19.04.08.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 04:09:00 -0700 (PDT) Message-ID: <402500e8-b4fe-9b8f-d634-e329191af1b8@linaro.org> Date: Wed, 19 Oct 2022 13:08:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] arm64: dts: meson: Enable active coling using gpio-fan on Odroid N2/N2+ Content-Language: en-US To: Anand Moon , Martin Blumenstingl Cc: Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221018195122.8877-1-linux.amoon@gmail.com> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Anand, On 19/10/2022 11:48, Anand Moon wrote: > Hi Martin, > > On Wed, 19 Oct 2022 at 08:36, Anand Moon wrote: >> >> Hi Martin, >> >> On Wed, 19 Oct 2022 at 02:46, Martin Blumenstingl >> wrote: >>> >>> Hello Anand, >>> >>> On Tue, Oct 18, 2022 at 9:53 PM Anand Moon wrote: >>>> >>>> Odroid N2/N2+ support active cooling via gpio-fan controller. >>>> Add fan controls and tip point for cpu and ddr thermal sensor >>>> on this boards. >>> In the schematics for board rev 0.6 [0] I cannot find any information >>> about a fan connector. >>> The schematics for board rev 0.3 [1] on the other hand document a PWM >>> based fan connector on page 16. >>> So now I am not sure whether your patch only applies to certain board >>> revisions, the schematics are incorrect, etc. >>> >>> Can you please provide some details about the fan connector on >>> Odroid-N2/N2+ and which hardware revisions are supported (and which >>> aren't) by your patch? >>> >>> >> Ok I got this wrong the schematics below there is pwm controller, not >> gpio controller >> GPIOAO.BIT10 (PWM) >> I will correct the patch sorry for the mistake I did not look more carefully. >> > > As per the schematics GPIOAO_10 is controlled by PWMAO_D > But looking into the datasheet [0] I could not find the relevant > PWMAO_D pmw ip block to link the fan to the PWM controller. > > [0] https://dn.odroid.com/S922X/ODROID-N2/Datasheet/S922X_Public_Datasheet_V0.2.pdf > > I could get the PWM node but is not working for me. > > @@ -547,6 +588,14 @@ &pwm_ab { > status = "okay"; > }; > > +&pwm_AO_ab { &pwm_AO_cd not _ab > + pinctrl-1 = <&pwm_ao_d_10_pins>; > + pinctrl-names = "default"; > + clocks = <&xtal>; > + clock-names = "clkin0"; > + status = "okay"; > +}; > + > > Thanks > -Anand > > >>> Thank you! >>> Martin >>> >>> >>> [0] https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf >>> [1] https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.3_20190117.pdf >> Thanks >> -Anand Neil