From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: improve rk3328-roc-cc rgmii performance. Date: Fri, 14 Jun 2019 11:39:55 +0200 Message-ID: <4025583.lUYsg5j2zl@phil> References: <20190607123731.8737-1-pgwipeout@gmail.com> <1559912295.22520.0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Peter Geis Cc: Jose Abreu , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Robin Murphy , "Leonidas P. Papadakos" List-Id: devicetree@vger.kernel.org Am Samstag, 8. Juni 2019, 01:07:48 CEST schrieb Peter Geis: > On Fri, Jun 7, 2019 at 8:58 AM Leonidas P. Papadakos > wrote: > > > > > > I'll test on my board, but if in the end it does end up being a change > > to both tx and rxpbl then we can replce the 2 tx/rxpbl options with > > one, as far as I know: > > > > snps,pbl = <0x4>; > > > > > > The big change was actually snps,aal. > As per the TRM, DMA channels not address aligned have severe > limitations, if they work at all. > > Setting the DMA ops as address aligned fixed my 30mbps TX issue when > combined with your snps,txpbl = <0x4>. same as with the other patch: I've lost track of what matters, so please resend the ones that matter with appropriate Tested-by, Reviewed-by tags by involved people. Thanks Heiko