From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Loc Ho <lho-qTEPVZfXA3Y@public.gmane.org>
Cc: bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
patches-qTEPVZfXA3Y@public.gmane.org
Subject: Re: [PATCH 1/3] Documentation: Update the APM X-Gene SoC EDAC DTS binding for missing RB
Date: Wed, 13 Jan 2016 00:07:15 +0100 [thread overview]
Message-ID: <4027351.WdK3AXxgBQ@wuerfel> (raw)
In-Reply-To: <1452639900-30919-2-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
On Tuesday 12 January 2016 16:04:58 Loc Ho wrote:
> --- a/Documentation/devicetree/bindings/edac/apm-xgene-edac.txt
> +++ b/Documentation/devicetree/bindings/edac/apm-xgene-edac.txt
> @@ -16,6 +16,7 @@ Required properties:
> - regmap-mcba : Regmap of the MCB-A (memory bridge) resource.
> - regmap-mcbb : Regmap of the MCB-B (memory bridge) resource.
> - regmap-efuse : Regmap of the PMD efuse resource.
> +- regmap-rb : Regmap of the register bus resource.
> - reg : First resource shall be the CPU bus (PCP) resource.
> - interrupts : Interrupt-specifier for MCU, PMD, L3, or SoC error
> IRQ(s).
> @@ -64,6 +65,11 @@ Example:
> reg = <0x0 0x1054a000 0x0 0x20>;
> };
>
> + rb: rb@7e000000 {
> + compatible = "apm,xgene-rb", "syscon";
> + reg = <0x0 0x7e000000 0x0 0x10>;
> + };
> +
> edac@78800000 {
> compatible = "apm,xgene-edac";
>
When you add a property, please list that as "optional", not "required",
to ensure that the old dtb files still conform to the binding.
In the driver, make sure it is not a fatal error when the property is
missing and the driver can keep working without it.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-12 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 23:04 [PATCH 0/3] edac: xgene: Add missing SoC register bus error handling and fix CE promotes to UE Loc Ho
[not found] ` <1452639900-30919-1-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2016-01-12 23:04 ` [PATCH 1/3] Documentation: Update the APM X-Gene SoC EDAC DTS binding for missing RB Loc Ho
[not found] ` <1452639900-30919-2-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2016-01-12 23:07 ` Arnd Bergmann [this message]
2016-01-12 23:24 ` Loc Ho
2016-01-12 23:04 ` [PATCH 2/3] edac: xgene: Add missing SoC register bus error handling and fix CE promotes to UE Loc Ho
2016-01-12 23:05 ` [PATCH 3/3] arm64: Update the APM X-Gene EDAC node with the RB register resource Loc Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4027351.WdK3AXxgBQ@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=lho-qTEPVZfXA3Y@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=patches-qTEPVZfXA3Y@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).