From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E658939FE2 for ; Mon, 22 Jan 2024 10:04:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705917848; cv=none; b=QGe0MomWpyHxQQe6MxiS+1BKMe7cVy44UIWUQR2FJ35Xw6sw51dV2zIbHIz7oOUgQ2+idGQR/eXDMQauZSfT6b+49sqjnASRHG87wgVJeOM4mIND37PefmcEDFmuMZN15KpqjA5OVophXXBcosFtjzZF6/8c1qJhBlGfYgRnibk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705917848; c=relaxed/simple; bh=M8pszskSh+59GT3YDDj2kTESCkFAakxa2ZaO1j5Q8Pg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GfzMQ43of+BfpTcRuCsVwyAB0JGLPDVzuhxhecR7+1UPNaswzXg/FjoC2cS3RDjq9GfTi5Yp0QIb3Q2WJbOUGWox+w+2QehPuO1GcfMDWXTH3GacLZsQPm0iiHN/ETquG+tV4ff23SHe8dMwROkNnONmtYBknMHrdERAkfVMmDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com; spf=pass smtp.mailfrom=tweaklogic.com; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b=I3B1Yr6z; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b="I3B1Yr6z" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5cf22a89a54so1162384a12.3 for ; Mon, 22 Jan 2024 02:04:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1705917846; x=1706522646; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ni6n5pqeZznTel6GtkjfHQ44EXROGMS+h3Fg1e6uKRc=; b=I3B1Yr6znb0vi9wz6wOHqDEKrWZP4rkZCZrZSss4+GiNn+XV4XipHkyIbOIA9Bn3zL i8MfXuHCIfKW0DtoovkckjFYvFDsxEf4bOOhPwi6OtcRMSvBtiVp0RibjWkXecDK+Xjz OxoeEDryvbw9LfBdgOfJpHG/KJbxfqB/yBUtDLDuGIdTzB1tHziZCB3/EItXa6db5eTW 5IwA1/HW0HV3Nf0OoZS2f7FRCwdmtuoh1L6/tfGM6tukbf1PueulY867b38NKdADcqR9 ojkTBqlnbXgSisnPc3blTR0AboVe4fSrISKq38IBosCLr17mRu/XQjun8zPBjXtnNjc1 gjkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705917846; x=1706522646; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ni6n5pqeZznTel6GtkjfHQ44EXROGMS+h3Fg1e6uKRc=; b=oFddHnR7kHJ+e+XeCHGYlqLUfiAgCFaeyjyPesaPZGQ+4dpKskigcNtn0h8LGl81h4 pqkC2HGlbWFcVH3DcjecooxXIAHusZwRMLbMsJQfi5NhZlihfhmCG4vVKhGHUJpW3SYk Pc0roGo55qIBSa9p4yP9BWopg+saXNjf8vUcJJyKEwWQeI9M8ifEtnWgpfLD+LFux4Bx Dm88ShZFZfrzQe+WY9cFdi5QJW4Ec0JNEHbYGwO2rfNSoq2JZrxYhIXJdIapmX/Pu4yT 5RXpeKGAR1/U4X6WOUoNRnb8CF+kVhP88CyQed/6Tt1Q0CthrrbEvTczBui1PBREqVAD pGzw== X-Gm-Message-State: AOJu0YzUb9LEv6qDaK7LEoKeYyl9T8TJ8bmH+rAHcFyUw5WsfTtPRO7d Bzvh71OHZekbxR1GPaMwW5O97u0g/sHtSVLi3cfNSMiqra7IvsotNBHyBUyjOTI= X-Google-Smtp-Source: AGHT+IFWhdobP+x4boZi7f4u5ncKwhvFSizCjj2v4j7C2QB2eYDiA0ptZEh6KxLq9DgxXVQGvcYSPQ== X-Received: by 2002:a05:6a20:9388:b0:199:b189:eb93 with SMTP id x8-20020a056a20938800b00199b189eb93mr1581609pzh.100.1705917846321; Mon, 22 Jan 2024 02:04:06 -0800 (PST) Received: from [192.168.20.11] ([180.150.112.156]) by smtp.gmail.com with ESMTPSA id d11-20020a17090b004b00b0028cef021d45sm9304508pjt.17.2024.01.22.02.04.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 02:04:05 -0800 (PST) Message-ID: <4031ee3e-9db5-4e36-8833-2f7fd6fad3ca@tweaklogic.com> Date: Mon, 22 Jan 2024 20:33:58 +1030 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] dt-bindings: iio: light: Avago APDS9306 Content-Language: en-US To: Jonathan Cameron Cc: Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Andy Shevchenko , Marek Vasut , Anshul Dalal , Javier Carrasco , Matt Ranostay , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240121051735.32246-1-subhajit.ghosh@tweaklogic.com> <20240121051735.32246-3-subhajit.ghosh@tweaklogic.com> <20240121153655.5f734180@jic23-huawei> From: Subhajit Ghosh In-Reply-To: <20240121153655.5f734180@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/1/24 02:06, Jonathan Cameron wrote: > On Sun, 21 Jan 2024 15:47:33 +1030 > Subhajit Ghosh wrote: > >> Adding device tree support for APDS9306 Ambient Light Sensor. >> Updating datasheet hyperlinks. >> Adding interrupt definition macro and header file. > > This is an unrelated change, so should probably be in a separate patch. Understood. > >> Adding vdd-supply property. > > This one is reasonable to have in same patch as the new device addition > as, whilst I assume it's valid for the existing devices, you are adding it > to incorporate something that device also has. > Could also be a separate precursor patch. > >> >> >> description: | >> - Datasheet: https://www.avagotech.com/docs/AV02-1077EN >> - Datasheet: https://www.avagotech.com/docs/AV02-4191EN >> + Datasheet: https://docs.broadcom.com/doc/AV02-1077EN >> + Datasheet: https://docs.broadcom.com/doc/AV02-4191EN >> + Datasheet: https://docs.broadcom.com/doc/AV02-4755EN > > Old links seem to still work, so why the change? My bad. I will revert to keep things simple. No reason, just thought of updating. Thanks for the review. Regards, Subhajit Ghosh