From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 2/2] net/smscx5xx: use the device tree for mac address Date: Thu, 04 Feb 2016 09:24 +0100 Message-ID: <40411294.EnLd2i85mo@wuerfel> References: <1454571364-24708-1-git-send-email-lkundrak@v3.sk> <1454571364-24708-3-git-send-email-lkundrak@v3.sk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1454571364-24708-3-git-send-email-lkundrak@v3.sk> Sender: linux-kernel-owner@vger.kernel.org To: Lubomir Rintel Cc: linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Chen , Olivier Blin , Stephen Warren , popcornmix List-Id: devicetree@vger.kernel.org On Thursday 04 February 2016 08:36:04 Lubomir Rintel wrote: > > [lkundrak@v3.sk: updated to use of_get_property() as per suggestion from Arnd, > reworded the message and comments a bit] > > Tested-by: Lubomir Rintel > Signed-off-by: Arnd Bergmann > --- > Looks good to me now. We could debate which MAC address should be used when both EEPROM and DT exist. The current version prefers the EEPROM address, and I think some other drivers do the opposite, but I don't really know which is best. Arnd