From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794491787; b=VhOPDgXWQjBqlVf5X7SwUfYTiX5zII0Vlnu9M6o4ThzJu3G8yE7met0Izu/RP1P7i+EH I+x+saXy7CHsyNWY5e00k/OElNOOo7E5C2Ix84dRWRWKhCyEzXqaMHETnDeZM6SOdTPnQ NIGHZ0TGDkbXevbwmd1FBEFa4dxYqUpV0ZJ+m+6jIX7TWPWBnoXDXDpqHbRbWc+a4wGuc alOggh1kq5i0OokKEwW7HzoEJ+wOLW/mX+hOA5eRChgRSlt3JM7G15/tgjuOr+XobMVt4 AWwxKAxtt/GqlwUqNMj7svHrmWNKrqXVJOOKFfb/M4E0XLQroQM+Gpy4x/23nor12ew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794491787; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=e3WkpQpA1mJ0C5moabXtGn0RQz1Qa9UFoLDbMZ87eds=; b=RUlNwdEj7DT6Oe2ASDX96hCxAzzUuSDyumoe+u/ejLfAjeRWyxit/BDjytdUCxOJa0OZ mrxJFFk3hFZMrtlrnxH8ycVvHA/PexL5uAvNK4lSsQvfztbiCAhd8tHoLZHqzsa7zvMkb OVTLQhjR4wUT7+yo4qwk2aSpV/bgIDr7AmMyC8HQ9gDkeYuZFH7M7/CWLf23Lm6ABuOaS KArztKpUxxO+ciR9FS2IJ2OIINyJodtLYkhNn9uXJSNBvySuuOjVa7XGtutNDO3qFizK2 WGygHCOMSeweeTy8Spf/lR12dGuBPEGuR3S4G4odiFfkJZtcZEd+1Dc9Fw+Nu/4F9Mw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=TGWHK1CU; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25C17606A323; Thu, 12 Nov 2026 13:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=TGWHK1CU Received: by smtp.kernel.org (Postfix) with ESMTPSA id 572B21F00A08; Thu, 12 Nov 2026 13:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794491786; bh=e3WkpQpA1mJ0C5moabXtGn0RQz1Qa9UFoLDbMZ87eds=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=TGWHK1CUOMPKgp7v0Y5U+1YNt8qCYHG7mmiIUCzYbs+atAmw3WG2cMqnyHz1uTyqb dGMHf/0OkHSepy4onuKkNUnyYyUBWMuJ5+uXDXGsuN8Hf2h75zPkRQ8NbDeF0QeRq/ wT3k7LklbR4Ze2EcOwDd6XRcBXddVWDwEqmVz/276+KPFcv/CNEUk5JNs/99zfdsb8 ZtstwIB7XdWQyVD38czxumO/UaDN0TSJLt69t6tsulhLUSVaudO34st+Cd99NkdwoT Q3yDevEZ5981Cm97CfCpox3OffD5t2FvIpSIPMLia+4jJ2PRUKHtXj3F26sBvYbTGp CLpOmLmG7r6EA== Message-ID: <4060e67a-553b-4e1b-9e17-e6a742e62a3a@kernel.org> Date: Thu, 12 Nov 2026 14:56:18 +0100 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] soc: qcom: geni-se: Define the QSPI firmware protocol To: Jyothi Kumar Seerapu Cc: Mark Brown , Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org References: <20261106-qspi_upstream_series-v1-0-21f43042dd60@oss.qualcomm.com> <20261106-qspi_upstream_series-v1-4-21f43042dd60@oss.qualcomm.com> <20261109-stimulating-oyster-of-respect-620b7b@quoll> <61646f06-87f1-48da-9b88-8898bb488af7@oss.qualcomm.com> <20261111-prudent-polite-shoebill-add35c@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/11/2026 14:48, Jyothi Kumar Seerapu wrote: > > > On 11/11/2026 6:10 PM, Krzysztof Kozlowski wrote: >> On Mon, Nov 09, 2026 at 08:13:33PM +0530, Jyothi Kumar Seerapu wrote: >>>>> -static const char * const protocol_name[] = { "None", "SPI", "UART", "I2C", "I3C", "SPI SLAVE" }; >>>>> +static const char * const protocol_name[] = { >>>>> + "None", "SPI", "UART", "I2C", "I3C", "SPI SLAVE", >>>>> + [GENI_SE_QSPI] = "QSPI", >>>> >>>> Why are you creating holes in this array? >>> >>> Hi Krzysztof, >>> The array is indexed by the GENI protocol ID. QSPI uses ID 9, while the >>> existing entries cover IDs 0–5, so the designated initializer leaves entries >>> 6–8 empty. >>> The added NULL check rejects these unused entries before accessing the >>> protocol name. Appending "QSPI" directly would incorrectly associate it with >>> ID 6. >> >> And it should be 6. Just look at uses of this. > > Hi Krzysztof, > > The QUP Hardware Programming Guide assigns protocol ID 9 to QSPI. > This enum represents the serial engine's protocol IDs, > rather than consecutive indices for the name table. > > The SPI/QSPI driver uses this ID to request the appropriate firmware > and validate the protocol read from GENI_FW_REVISION_RO. The firmware > loader also matches this ID against the firmware header's protocol > field. Changing QSPI to 6 would make these checks expect a different > protocol ID. You miss the point. This is just a table for Linux driver, not what is programmed. So please explain me, if firmware comes with new protocol, e.g. OSPI with id 10000000, are you going to use that as an index? Really, why are we discussing this? Best regards, Krzysztof