From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Laszlo Ersek <lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [kernel PATCH] devicetree: document ARM bindings for QEMU's Firmware Config interface
Date: Fri, 28 Nov 2014 13:59:43 +0100 [thread overview]
Message-ID: <4081425.dh6XptxTnn@wuerfel> (raw)
In-Reply-To: <1417177604-21194-1-git-send-email-lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Friday 28 November 2014 13:26:44 Laszlo Ersek wrote:
> +Example:
> +
> +/ {
> + #size-cells = <0x2>;
> + #address-cells = <0x2>;
> +
> + fw-cfg@9020000 {
> + reg = <0x0 0x9020000 0x0 0x2 0x0 0x9020002 0x0 0x1>;
> + compatible = "fw-cfg,mmio";
> + };
> +};
>
"fw-cfg" is not a valid vendor string. Are you emulating an actual piece
of hardware here or is this something that comes from qemu?
How about using "qemu,fwcfg" as the compatible string, and documenting
"qemu" as an official vendor string in Documentation/devicetree/bindings/vendor-prefixes.txt
We don't normally list contiguous registers separately. Maybe just round
up to one page and make the register property
reg = <0x0 0x9020000 0x0 0x1000>;
Finally, isn't there also an interrupt associated with this virtual device?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-28 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 12:26 [kernel PATCH] devicetree: document ARM bindings for QEMU's Firmware Config interface Laszlo Ersek
[not found] ` <1417177604-21194-1-git-send-email-lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-28 12:59 ` Arnd Bergmann [this message]
2014-11-28 13:22 ` Laszlo Ersek
[not found] ` <54787715.6030407-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-28 13:33 ` Mark Rutland
2014-11-28 13:49 ` Laszlo Ersek
2014-11-28 13:17 ` Mark Rutland
2014-11-28 13:47 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4081425.dh6XptxTnn@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox