From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE79C433EF for ; Wed, 29 Jun 2022 08:03:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231744AbiF2IDq (ORCPT ); Wed, 29 Jun 2022 04:03:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbiF2IDp (ORCPT ); Wed, 29 Jun 2022 04:03:45 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41A6929830 for ; Wed, 29 Jun 2022 01:03:43 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id g26so30890627ejb.5 for ; Wed, 29 Jun 2022 01:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=cG3vzXy564NxPyQk6j0mH7QQcpmGhb7eglXugVj6hN8=; b=YPK4Y9MtYTlB+9uxDmydPXAD+nm40vRi5kfqNUZQCbI9XYMlU0HSOwbzR6G6bfbW4r F0Zn6240auG9wDCOE9n576wvCFBDgppCXYG/GGdNxBsOj22QcVc7t6BadRxqNBFanvmZ Hj53k762IYyi8RlPckGPXe0GiV3fZlE/f5hgZxLs3SHfwPyJi4N+lVi1HN+S2PINJ23v kp9yJ05aEzIO7rA8z5nrXEOU7q1BAXOszAd9SqDfvt6GNNB+XktIVwUkJTC5bAKL1kpy ZhhY/RXn66UpmjVKgVL/s3pDCyWB5ZJw9FC7ZT4el0lubErnU7RHGWnvC/2zexKIC71j ZQoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cG3vzXy564NxPyQk6j0mH7QQcpmGhb7eglXugVj6hN8=; b=m0qk2MG6YKPQdbZVp7IlDWANnBWn0ZafHftx4d6cgeNuMnz+5ymh0YhgRXula5VU8F qQ5SUMiv66MVlRXTTLNzOr6p0YV28cm5CaJXKCA+EytpVUBk+kXDSAlWCoIeczACFbAC GRM1y6zkVNM+AMIrBbXKGfBz1RmpozTOCly35xUV2BNWkbB2zEoGuZt+HsuUPcyJBo7U 1JIZbbIiIqVfXbNLdD/ant6QSufxcLhOCau9pqWy4rKsEvYEUpHpfceEVyOv5Lnn/jmp ViGiZTwlDuEvdaNZMKBPIh6lvChYZYyCJf+fSO3ojVm1sDEN40kD7h2u9aZLv/J5vdOP P2YA== X-Gm-Message-State: AJIora+qtVDfQeUJGsltm9irujZr0jnpJwtVO5uT47GOyLi6aJMLdRLb UgSinHEdbQIryMHgpS/2IQBXRg== X-Google-Smtp-Source: AGRyM1vMLNNjC9XXtRvbH3wYlHBLBB1LEnGfbV9c7vENLF2zfPQTUdrjciEn2ZM1kvAcRAd4swllrQ== X-Received: by 2002:a17:907:168f:b0:726:2bd0:1091 with SMTP id hc15-20020a170907168f00b007262bd01091mr2003312ejc.137.1656489821764; Wed, 29 Jun 2022 01:03:41 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id g20-20020a50d5d4000000b0042617ba63c2sm10991337edj.76.2022.06.29.01.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 01:03:40 -0700 (PDT) Message-ID: <409af908-5e03-8df7-fcd5-7fab75cdfb34@linaro.org> Date: Wed, 29 Jun 2022 10:03:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Content-Language: en-US To: Neal Liu , Corentin Labbe , Christophe JAILLET , Randy Dunlap , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Dhananjay Phadke , Johnny Huang Cc: "linux-aspeed@lists.ozlabs.org" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BMC-SW References: <20220629032008.1579899-1-neal_liu@aspeedtech.com> <20220629032008.1579899-3-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/06/2022 09:59, Neal Liu wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Wednesday, June 29, 2022 1:58 PM >> To: Neal Liu ; Corentin Labbe >> ; Christophe JAILLET >> ; Randy Dunlap ; >> Herbert Xu ; David S . Miller >> ; Rob Herring ; Krzysztof >> Kozlowski ; Joel Stanley ; >> Andrew Jeffery ; Dhananjay Phadke >> ; Johnny Huang >> >> Cc: linux-aspeed@lists.ozlabs.org; linux-crypto@vger.kernel.org; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-kernel@vger.kernel.org; BMC-SW >> Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE >> reset definition >> >> On 29/06/2022 05:20, Neal Liu wrote: >>> Add HACE reset bit definition for AST2500/AST2600. >>> >>> Signed-off-by: Neal Liu >>> Signed-off-by: Johnny Huang >>> Acked-by: Krzysztof Kozlowski >>> --- >>> include/dt-bindings/clock/aspeed-clock.h | 3 ++- >>> include/dt-bindings/clock/ast2600-clock.h | 1 + >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/dt-bindings/clock/aspeed-clock.h >>> b/include/dt-bindings/clock/aspeed-clock.h >>> index 9ff4f6e4558c..6e040f7c3426 100644 >>> --- a/include/dt-bindings/clock/aspeed-clock.h >>> +++ b/include/dt-bindings/clock/aspeed-clock.h >>> @@ -46,11 +46,12 @@ >>> #define ASPEED_RESET_MCTP 1 >>> #define ASPEED_RESET_ADC 2 >>> #define ASPEED_RESET_JTAG_MASTER 3 >>> -#define ASPEED_RESET_MIC 4 >>> +#define ASPEED_RESET_HACE 4 >> >> I did not ack such change. This is a significant change from previous version, >> invalidating my previous ack. >> >> This breaks the ABI, so NAK without proper explanation why ABI break is >> accepted. > > I changed the original define (MIC) into different value (see below diff), and add a new define for HACE. > How does that break the ABI? I'll be appreciated if you can explain it more details. > And sorry for not remove ack with new change. Yes, this breaks ABI. Previously the ASPEED_RESET_MIC define had value of 4, now it has value of something else. Best regards, Krzysztof