From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, daniel.baluta@nxp.com,
dario.binacchi@amarulasolutions.com,
alexander.stein@ew.tq-group.com, Markus.Niebel@tq-group.com,
matthias.schiffer@tq-group.com, y.moog@phytec.de,
josua@solid-run.com, francesco.dolcini@toradex.com,
primoz.fiser@norik.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Frank.Li@nxp.com,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: add support for NXP i.MX8MP audio board (version 2)
Date: Wed, 25 Feb 2026 11:39:17 +0100 [thread overview]
Message-ID: <409f6214-7ffd-4076-a658-f4005adbe101@kernel.org> (raw)
In-Reply-To: <20260224094527.169215-3-shengjiu.wang@nxp.com>
On 24/02/2026 10:45, Shengjiu Wang wrote:
> +
> +&ecspi2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> + pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
> + pinctrl-names = "default";
> + status = "okay";
> +
> + spidev1: spi@0 {
> + compatible = "rohm,dh2228fv";
NAK
You don't have there. Stop faking up hardware. NXP received this comment
multiple times already.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-25 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 9:45 [PATCH 0/2] arm64: dts: Add NXP i.MX8MP audio board support Shengjiu Wang
2026-02-24 9:45 ` [PATCH 1/2] dt-bindings: arm: fsl: Add compatible for i.MX8MP audio board (version 2) Shengjiu Wang
2026-02-24 17:59 ` Conor Dooley
2026-02-24 9:45 ` [PATCH 2/2] arm64: dts: add support for NXP " Shengjiu Wang
2026-02-24 10:27 ` Fabio Estevam
2026-02-25 6:26 ` Shengjiu Wang
2026-02-25 10:39 ` Krzysztof Kozlowski [this message]
2026-02-25 12:48 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409f6214-7ffd-4076-a658-f4005adbe101@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Markus.Niebel@tq-group.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=imx@lists.linux.dev \
--cc=josua@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@tq-group.com \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox