From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Minyard Subject: Re: [PATCH v3 0/3] ARM: aspeed: add support for the BT IPMI interface Date: Tue, 20 Sep 2016 09:58:40 -0500 Message-ID: <40bb95a8-b5a6-563b-11c6-73de2f67130d@acm.org> References: <1474354900-5618-1-git-send-email-clg@kaod.org> Reply-To: minyard-HInyCGIudOg@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1474354900-5618-1-git-send-email-clg-Bxea+6Xhats@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , openipmi-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Joel Stanley Cc: Alistair Popple , Rob Herring , Mark Rutland , Russell King , Arnd Bergmann , Jeremy Kerr , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/20/2016 02:01 AM, Cédric Le Goater wrote: > Hello, > > This serie adds support for the iBT interface on Aspeed SOCs (AST2400 > and AST2500). The BT (Block Transfer) interface is used to perform > in-band IPMI communication between a host and its BMC. This driver > implements the BMC side. This looks good. I pulled these into my tree, it's ok for 4.9 or whatever is next, since it's a new driver. Do patches 2 and 3 go through Joel? -corey > Changes since v2: > > - limit to one opener > - protect write/read operations with a mutex. > > Changes since v1: > > - the driver is now called 'bt-bmc' and the device node '/dev/ipmi-bt-host' > > - the code is now under drivers/char/ipmi/. This required a change of > the top Makefile in drivers/ to compile the bt-bmc driver with the > ipmi handlers not being selected. That might be an issue. > > - changed the read/write operations to use a temporary buffer and get > rid of the {get,put}_user calls > > Thanks, > > C. > > Alistair Popple (1): > ipmi: add an Aspeed BT IPMI BMC driver > > Cédric Le Goater (2): > ARM: aspeed: Add defconfigs for CONFIG_ASPEED_BT_IPMI_BMC > ARM: dts: aspeed: Enable BT IPMI BMC device > > .../bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt | 23 + > arch/arm/boot/dts/aspeed-g4.dtsi | 6 + > arch/arm/boot/dts/aspeed-g5.dtsi | 6 + > arch/arm/configs/aspeed_g4_defconfig | 1 + > arch/arm/configs/aspeed_g5_defconfig | 1 + > drivers/Makefile | 2 +- > drivers/char/ipmi/Kconfig | 7 + > drivers/char/ipmi/Makefile | 1 + > drivers/char/ipmi/bt-bmc.c | 510 +++++++++++++++++++++ > include/uapi/linux/Kbuild | 1 + > include/uapi/linux/bt-bmc.h | 18 + > 11 files changed, 575 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt > create mode 100644 drivers/char/ipmi/bt-bmc.c > create mode 100644 include/uapi/linux/bt-bmc.h > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html