Re: [PATCH 4/4] mips: bmips: dts: fix qspi register order

Krzysztof Kozlowski
2025-12-25T12:35:26Z

On 25/12/2025 11:25, Jonas Gorski wrote:
> Align the register order to the schema. Fixes warnings like:
>
> arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@41d200 (brcm,spi-brcmstb-qspi): reg-names:0: 'cs_reg' is not one of ['hif_mspi', 'mspi']
> from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml
> arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@41d200 (brcm,spi-brcmstb-qspi): reg-names:1: 'bspi' was expected
> from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml
> arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@41d200 (brcm,spi-brcmstb-qspi): reg-names:2: 'bspi' is not one of ['intr_regs', 'intr_status_reg', 'cs_reg']
> from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml

Trim redundant parts. You do not need to paste schema path every time.
Full path to DTB also is not really necessary, IMO.

>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
> arch/mips/boot/dts/brcm/bcm7125.dtsi | 4 ++--
> arch/mips/boot/dts/brcm/bcm7346.dtsi | 4 ++--
> arch/mips/boot/dts/brcm/bcm7358.dtsi | 4 ++--
> arch/mips/boot/dts/brcm/bcm7360.dtsi | 4 ++--
> arch/mips/boot/dts/brcm/bcm7362.dtsi | 4 ++--
> arch/mips/boot/dts/brcm/bcm7420.dtsi | 4 ++--
> arch/mips/boot/dts/brcm/bcm7425.dtsi | 4 ++--
> arch/mips/boot/dts/brcm/bcm7435.dtsi | 4 ++--
> 8 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/arch/mips/boot/dts/brcm/bcm7125.dtsi b/arch/mips/boot/dts/brcm/bcm7125.dtsi
> index dd1cc3cda694..81ee0f49b645 100644
> --- a/arch/mips/boot/dts/brcm/bcm7125.dtsi
> +++ b/arch/mips/boot/dts/brcm/bcm7125.dtsi
> @@ -250,8 +250,8 @@ qspi: spi@443000 {
> compatible = "brcm,spi-brcmstb-qspi",
> "brcm,spi-bcm-qspi";
> clocks = <&upg_clk>;
> - reg = <0x440920 0x4 0x443200 0x188 0x443000 0x50>;
> - reg-names = "cs_reg", "hif_mspi", "bspi";
> + reg = <0x443200 0x188 0x443000 0x50 0x440920 0x4>;
> + reg-names = "hif_mspi", "bspi", "cs_reg";

So order is anyway broken by this change, thus you can as well rename it
to mspi, right?

Best regards,
Krzysztof