[PATCH V4 0/2] Enable TRNG for QCS8300

[PATCH V4 0/2] Enable TRNG for QCS8300

[Yuvaraj Ranganathan]

Add device-tree nodes to enable TRNG for QCS8300

This series depends on below patch series:
https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/ - Reviewed

Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com>
---
Changes in v4:
 - Address the reg entry style
 - Link to v3: https://lore.kernel.org/all/20241113021819.2616961-1-quic_yrangana@quicinc.com/

Changes in v3:
 - Drop DT label as per review comments
 - Link to v2: https://lore.kernel.org/all/20241107121513.641281-1-quic_yrangana@quicinc.com/

Changes in v2:
 - Mistakenly uploaded the base dtsi change instead of marking dependency
 - Link to v1: https://lore.kernel.org/all/20241106110002.3054839-1-quic_yrangana@quicinc.com/

---
Yuvaraj Ranganathan (2):
  dt-bindings: crypto: qcom,prng: document QCS8300
  arm64: dts: qcom: qcs8300: add TRNG node

 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
 arch/arm64/boot/dts/qcom/qcs8300.dtsi                   | 5 +++++
 2 files changed, 6 insertions(+)

-- 
2.34.1

[PATCH V4 1/2] dt-bindings: crypto: qcom,prng: document QCS8300

[Yuvaraj Ranganathan]

Document QCS8300 compatible for the True Random Number
Generator.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com>
---
 Documentation/devicetree/bindings/crypto/qcom,prng.yaml    |  1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 048b769a73c0..2c959162e428 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -17,6 +17,7 @@ properties:
           - qcom,prng-ee  # 8996 and later using EE
       - items:
           - enum:
+              - qcom,qcs8300-trng
               - qcom,sa8255p-trng
               - qcom,sa8775p-trng
               - qcom,sc7280-trng

[PATCH V4 2/2] arm64: dts: qcom: qcs8300: add TRNG node

[Yuvaraj Ranganathan]

The qcs8300 SoC has a True Random Number Generator, add the node with
the correct compatible set.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org>
Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
index 2c35f96c3f28..a95baa432872 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
@@ -588,6 +588,11 @@ &clk_virt SLAVE_QUP_CORE_0 0>,
 			};
 		};
 
+		rng@10d2000 {
+			compatible = "qcom,qcs8300-trng", "qcom,trng";
+			reg = <0x0 0x010d2000 0x0 0x1000>;
+		};
+
 		config_noc: interconnect@14c0000 {
 			compatible = "qcom,qcs8300-config-noc";
 			reg = <0x0 0x014c0000 0x0 0x13080>;
-- 
2.34.1

Re: [PATCH V4 2/2] arm64: dts: qcom: qcs8300: add TRNG node

[Krzysztof Kozlowski]

On 22/11/2024 08:43, Yuvaraj Ranganathan wrote:
> The qcs8300 SoC has a True Random Number Generator, add the node with
> the correct compatible set.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org>

NAK, stop adding fake tags. It is impossible to receive above tag from
me written that way.

Best regards,
Krzysztof

Re: [PATCH V4 2/2] arm64: dts: qcom: qcs8300: add TRNG node

[Yuvaraj Ranganathan]

Hi Krzysztof,

I sincerely apologize for the inconvenience. I added the "Reviewed-by"
tag without fully understanding its implications. I will remove the tag
in the next patch series.

Thanks,
Yuvaraj.

On 11/22/2024 8:30 PM, Krzysztof Kozlowski wrote:
> On 22/11/2024 08:43, Yuvaraj Ranganathan wrote:
>> The qcs8300 SoC has a True Random Number Generator, add the node with
>> the correct compatible set.
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org>
> 
> NAK, stop adding fake tags. It is impossible to receive above tag from
> me written that way.
> 
> Best regards,
> Krzysztof

Re: [PATCH V4 2/2] arm64: dts: qcom: qcs8300: add TRNG node

[Dmitry Baryshkov]

On Sun, Nov 24, 2024 at 09:17:40AM +0530, Yuvaraj Ranganathan wrote:
> Hi Krzysztof,
> 
> I sincerely apologize for the inconvenience. I added the "Reviewed-by"
> tag without fully understanding its implications. I will remove the tag
> in the next patch series.

First of all, please don't top-post. Put your text under the phrases
that you are responding to, not at the top of the message. Otherwise the
logic is a bit broken.

Second, may I ask, what made you add that tag at all? I went on and
checked. Krzysztof didn't repond at all to v3 and didn't respond to v2
of this patch. So why?

Third, if you are unsure about what you are doing and as you seem to be
using b4 tool, please just use `b4 trailers -u`. It has its own
drawbacks so in some cases one should be careful, but at least it
doesn't invent tags on its own.

> 
> Thanks,
> Yuvaraj.
> 
> On 11/22/2024 8:30 PM, Krzysztof Kozlowski wrote:
> > On 22/11/2024 08:43, Yuvaraj Ranganathan wrote:
> >> The qcs8300 SoC has a True Random Number Generator, add the node with
> >> the correct compatible set.
> >>
> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > 
> > NAK, stop adding fake tags. It is impossible to receive above tag from
> > me written that way.
> > 
> > Best regards,
> > Krzysztof
> 

-- 
With best wishes
Dmitry

Re: [PATCH V4 2/2] arm64: dts: qcom: qcs8300: add TRNG node

[Yuvaraj Ranganathan]

On 11/26/2024 4:05 AM, Dmitry Baryshkov wrote:
> On Sun, Nov 24, 2024 at 09:17:40AM +0530, Yuvaraj Ranganathan wrote:
>> Hi Krzysztof,
>>
>> I sincerely apologize for the inconvenience. I added the "Reviewed-by"
>> tag without fully understanding its implications. I will remove the tag
>> in the next patch series.
> 
> First of all, please don't top-post. Put your text under the phrases
> that you are responding to, not at the top of the message. Otherwise the
> logic is a bit broken.
> 
> Second, may I ask, what made you add that tag at all? I went on and
> checked. Krzysztof didn't repond at all to v3 and didn't respond to v2
> of this patch. So why?
> 
> Third, if you are unsure about what you are doing and as you seem to be
> using b4 tool, please just use `b4 trailers -u`. It has its own
> drawbacks so in some cases one should be careful, but at least it
> doesn't invent tags on its own.
> 
>>
>> Thanks,
>> Yuvaraj.
>>
>> On 11/22/2024 8:30 PM, Krzysztof Kozlowski wrote:
>>> On 22/11/2024 08:43, Yuvaraj Ranganathan wrote:
>>>> The qcs8300 SoC has a True Random Number Generator, add the node with
>>>> the correct compatible set.
>>>>
>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>>
>>> NAK, stop adding fake tags. It is impossible to receive above tag from
>>> me written that way.
>>>
>>> Best regards,
>>> Krzysztof
>>
> 

I've added the "Reviewed-by" tag without a proper understanding as I got
few comments
(https://lore.kernel.org/all/4009f4ee-2c55-4a4f-8805-eafe7efc0147@kernel.org/)
 on the earlier patches and tagged the reviewers under "Reviewed-by". I
sincerely apologize on this and will ensure to avoid such mistakes in
future.

Thanks,
Yuvaraj.