Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Iranna Mundaganur <iranna.mundaganur@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sairamreddy Bojja <sairamreddy.bojja@oss.qualcomm.com>
Subject: Re: [PATCH] arm64: dts: qcom: glymur: Fix missing SMMU stream IDs for ADSP
Date: Wed, 19 Aug 2026 13:46:28 +0200	[thread overview]
Message-ID: <40c85916-6694-4976-95be-6ce2a2f19732@oss.qualcomm.com> (raw)
In-Reply-To: <20260811-adsp-smmu-fix-v1-1-a596d284c455@oss.qualcomm.com>

On 8/11/26 6:44 PM, Iranna Mundaganur wrote:
> From: Sairamreddy Bojja <sairamreddy.bojja@oss.qualcomm.com>
> 
> Add the missing SIDs for the LPASS eNPU masters to the ADSP
> iommus list. These masters are exercised during audio record
> use cases where Environmental Acoustic Intelligence (EAI)
> models run on the eNPUs.

Could you share a bit more details on how we can reproduce t his?

> Currently all transactions from these eNPU masters will result
> in global faults; fix them by adding the additional SIDs.
> 
> Fixes: cd1d174c75f7 ("arm64: dts: qcom: glymur: Add ADSP and CDSP for Glymur SoC")
> Signed-off-by: Sairamreddy Bojja <sairamreddy.bojja@oss.qualcomm.com>
> Co-developed-by: Iranna Mundaganur <iranna.mundaganur@oss.qualcomm.com>
> Signed-off-by: Iranna Mundaganur <iranna.mundaganur@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/glymur.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index f04058d2e089..6b06e0acbcf0 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> @@ -4084,7 +4084,9 @@ remoteproc_adsp: remoteproc@6800000 {
>  			compatible = "qcom,glymur-adsp-pas", "qcom,sm8550-adsp-pas";
>  			reg = <0x0 0x06800000 0x0 0x10000>;
>  
> -			iommus = <&apps_smmu 0x1000 0x0>;
> +			iommus = <&apps_smmu 0x1000 0x0>,
> +				 <&apps_smmu 0x1040 0x20>,

The correct SID base is 0x1060 (although the mask makes them equivalent)

> +				 <&apps_smmu 0x1080 0x0>;

This will bind the eNPU streams together with the ADSP firmware stream
into a single iommu domain - is that your intent?

Konrad

  parent reply	other threads:[~2026-08-19 11:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 16:44 [PATCH] arm64: dts: qcom: glymur: Fix missing SMMU stream IDs for ADSP Iranna Mundaganur
2026-08-11 19:41 ` Abel Vesa
2026-08-19 11:46 ` Konrad Dybcio [this message]
2026-08-21  7:24   ` Iranna Mundaganur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40c85916-6694-4976-95be-6ce2a2f19732@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iranna.mundaganur@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sairamreddy.bojja@oss.qualcomm.com \
    --cc=sibi.sankar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox