From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1347C3DA7D for ; Fri, 23 Dec 2022 13:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236271AbiLWNUw (ORCPT ); Fri, 23 Dec 2022 08:20:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236209AbiLWNUt (ORCPT ); Fri, 23 Dec 2022 08:20:49 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EBAB2C8 for ; Fri, 23 Dec 2022 05:20:45 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id 1so7099448lfz.4 for ; Fri, 23 Dec 2022 05:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KgXa7/ukKMDocBnSe76XCFCBNMSd8+VIWyqtqQC5em4=; b=ny+RJdlJjYX4oriRqkBq5wTqCbuZUgAFx0hsZrYWJaHlP8hrJKv9pFyAA8Cwb3lRTR NgVZdfRm3Y1OPp6uofb4Zhi4QXoZmzwcI5pd29DYiHGEV7QRm089RMQBYwmS+xGbhMe/ eWKloaNTsFNb3BsZcjhNQVinnpnQBW89XjICfXYJYJqdkSvEagu5hsFNQ8WWVSEj2cie 61pGJF66HZC88lZaIE9tcw1RwtXedBru1NW2+rj6yrAiAHiDB0JjQ+vwrCuQdIkvkLgO u+fAdgQmPSgAq9cYKkltJ8NciyxSMlT3qv7a3vdSyw1kNiuxWyN/GWGvnqJdpuZ8K52E 816g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KgXa7/ukKMDocBnSe76XCFCBNMSd8+VIWyqtqQC5em4=; b=3qh2lhuLv1saUdFOZlaTRqcCtzCdNYdwA/5sAJF7RnXxyrxicjcV5ebubkEKQLE3KX 3ZNPS7mQKvQrDnEXFVaTVpaOPJ7XAnUCMIny8ICTvjoTZLHIlvdQNfHtbFMOIOBSdILN +nrX73lsQ9QNPKyjMARiLGo0tZpIA5tzhNmirs4xn/FepPuvfGrEYAhyaiw7HoxE51CZ H4AhL8LJEBGglXinxrf5fG3nHVavI1Vr+8LqG7J3Es7i22rt5zV6hAVVkmNFv7NvLEhS i+JfJEplCXtX4DLrMOUcSAnGxabtBYAYuzIiZ/ULVXFh49L/2xFKxfyKqTS0gn2pp+1k kUBQ== X-Gm-Message-State: AFqh2krWezdbJ4JlCxO5Tt0fJvJ2+Ls/GzH3nFUOJ/b/g13NMIiJDVxL Iy31qROYqbUChZuzdO3nfccEmoniCAitRgqd X-Google-Smtp-Source: AMrXdXu99h0V8bKpeI66+rDGMCQJOZIp9zbdyJJu4Sggxux8Uel0/kwII85uWGyqk4iAICAyAKAyMw== X-Received: by 2002:ac2:5088:0:b0:4b9:a91c:b0cb with SMTP id f8-20020ac25088000000b004b9a91cb0cbmr2846591lfm.57.1671801643924; Fri, 23 Dec 2022 05:20:43 -0800 (PST) Received: from [192.168.1.101] (abyl184.neoplus.adsl.tpnet.pl. [83.9.31.184]) by smtp.gmail.com with ESMTPSA id d13-20020a056512368d00b0049478cc4eb9sm516424lfs.230.2022.12.23.05.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 05:20:43 -0800 (PST) Message-ID: <40ce6134-e3e8-c3c7-8ba0-539b1ce3fc7c@linaro.org> Date: Fri, 23 Dec 2022 14:20:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 3/5] arm64: dts: qcom: sm6125-seine: Provide regulators to SDHCI 1 Content-Language: en-US To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221222203636.250190-1-marijn.suijten@somainline.org> <20221222203636.250190-4-marijn.suijten@somainline.org> <20221223130813.qk7thawdueugb5z4@SoMainline.org> From: Konrad Dybcio In-Reply-To: <20221223130813.qk7thawdueugb5z4@SoMainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23.12.2022 14:08, Marijn Suijten wrote: > On 2022-12-23 13:00:18, Konrad Dybcio wrote: >> >> >> On 22.12.2022 21:36, Marijn Suijten wrote: >>> While SDHCI 1 appears to work out of the box, we cannot rely on the >>> bootloader-enabled regulators nor expect them to remain enabled (e.g. >>> when finally dropping pd_ignore_unused). >> >> Unrelated, unused-yet-enabled (as far as Linux is concerned, anyway, >> it doesn't know the state of smd rpm regulators unless you add >> regulator-boot-on) regulators get swept by "regulator cleanup". > > That's exactly the point made here: at least this way Linux knows that > these regulators should remain enabled. Even if it doesn't know about > many others and would fall flat on its face regardless when disabling > others as part of regulator cleanup. > > Unless you meant something different? I meant that regulators are not handled by pd_ignore_unused, but rather by a similar mechanism. Konrad > > - Marijn