From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE4AC7619A for ; Mon, 27 Mar 2023 09:16:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233101AbjC0JQG (ORCPT ); Mon, 27 Mar 2023 05:16:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233104AbjC0JQF (ORCPT ); Mon, 27 Mar 2023 05:16:05 -0400 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCADC4225; Mon, 27 Mar 2023 02:16:00 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 7C972320084E; Mon, 27 Mar 2023 05:15:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 27 Mar 2023 05:15:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undef.tools; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1679908558; x=1679994958; bh=D6nNTX0D5vA8BTdg4fTxXWIrP7TJxRhrZG5 DkHgHPUg=; b=xtrmlM7g2RJAHTuKggOp5ZHWRHpVyMfcrp51M5bzZsy/VHub+pQ 6NelFxmwu8mtsa2Eu8ApG1q1zQFRz2NiDpwk6Myir+kwXjRRUJTudTTXtHWJBgtp aIOCFM9Xr787C9guxF5Nl+5LWyjwuiva9X1x5xBqDZlDOxRQomp2RbHE6HRmPaDH gJ++tJ7ecDEpakLxaNH5HSB3l91PaMl9i2VK4V9DasBOPk+ohUEDZGdGozeHjgG6 Kr58jBv6EUNQJi3bLeCIKKSuaeztqfLXFt1zss1u3TdGSV3+398W2I5cfE1Mjsg5 7Ow9WVpxacIXsjIfMq9rcVaVA0icOjptzBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679908558; x=1679994958; bh=D6nNTX0D5vA8BTdg4fTxXWIrP7TJxRhrZG5 DkHgHPUg=; b=PrCIB5DaJ5Uk2W4j7BZy5R2DKTH2qEMbrxjWnBuybRd1664L6Sa 23kddC4HZG7yS8WC4UiplJ8TmdwCrWi9k9vsUqygUliJ4tccNtVSAvIblrUH2GxP 9lqZqRrQnMEFOqlja/V3oKSVOeJjAcLKZXJrV8hRxwrjqkZ3dKTwzaF9pVJJfHkG /2BR74WXrfNsKmTRSfQAsxjEqWmydeuubRR8+oSUHZG1onyUwmIAVSBxwG9wcGl0 m6twyVF+66FSjBX574irZvLJnMbLUnyTCjU/4tGcpi6tG09aGSuPskdqCZ12p+3q TDkGAo0JfgIopXTFZaSpR3tkZRHjBCBTH2g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflrghr rhgrhhcuoehkvghrnhgvlhesuhhnuggvfhdrthhoohhlsheqnecuggftrfgrthhtvghrnh epgefgjedtudfgueejfeegueeiieduleetueekfffhieekudduvedtvdfhtdejudehnecu ffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehkvghrnhgvlhesuhhnuggvfhdrthhoohhlsh X-ME-Proxy: Feedback-ID: id76147eb:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Mar 2023 05:15:52 -0400 (EDT) Message-ID: <40e61776-bcdd-25ac-286a-1ba0184dbd7e@undef.tools> Date: Mon, 27 Mar 2023 20:15:46 +1100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Robert Mader , Laurent Pinchart , Peter Robinson , Jacopo Mondi , Ondrej Jirman , Martijn Braam , =?UTF-8?Q?Kamil_Trzci=c5=84ski?= , Caleb Connolly , Krzysztof Kozlowski , Rob Herring , Tom Fitzhenry , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20230327074136.1459212-1-javierm@redhat.com> <8197476.T7Z3S40VBb@diego> From: Jarrah In-Reply-To: <8197476.T7Z3S40VBb@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 3/27/23 20:11, Heiko Stübner wrote: > Am Montag, 27. März 2023, 09:55:15 CEST schrieb Jarrah: >> Hi Javier, >> >> On 3/27/23 18:41, Javier Martinez Canillas wrote: >>> From: Ondrej Jirman >>> >>> The phone's display is using a Hannstar LCD panel. Support it by adding a >>> panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc). >>> >>> Signed-off-by: Ondrej Jirman >>> Co-developed-by: Martijn Braam >>> Co-developed-by: Kamil Trzciński >>> Signed-off-by: Javier Martinez Canillas >>> --- >>> >>> Changes in v2: >>> - Drop touchscreen node because used the wrong compatible (Ondrej Jirman). >> >> Any reason not to include this with the correct compatible string? It's >> been available since >> https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/. >> Swapping out gt917s for gt1158 in the node from your previous patch >> should be enough. > Just wondering if I'm blind, Javier's patch doesn't contain any touchscreen > controller (haven't found neither gt9* or gt11* mentioned there), so > I'm inclined to go with the "touchscreen can be added later" thing. I was just commenting on the "Changes in v2" section. v1 had a touchscreen node in it (assuming I found the right v1). All good, I can follow up with a patch for the touchscreen.