* [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes
@ 2022-11-18 18:25 Melody Olvera
2022-11-21 10:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Melody Olvera @ 2022-11-18 18:25 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: Melody Olvera, open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Update the bindings to allow for generic regulator nodes instead of
device-specific node names.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
This patch comes from discussions on [1] and is separated out. It also
has updated pattern matching to match the comments left from [1].
[1] https://lore.kernel.org/all/20221026200429.162212-2-quic_molvera@quicinc.com/
Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
index b246500d3d5d..23ee56bfa636 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
@@ -112,8 +112,9 @@ properties:
$ref: /schemas/power/qcom,rpmpd.yaml#
patternProperties:
- '-regulators$':
+ '^regulators(-[01])?$':
$ref: /schemas/regulator/qcom,rpmh-regulator.yaml#
+ unevaluatedProperties: false
required:
- compatible
base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes
2022-11-18 18:25 [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes Melody Olvera
@ 2022-11-21 10:27 ` Krzysztof Kozlowski
2022-11-22 11:41 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 10:27 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 18/11/2022 19:25, Melody Olvera wrote:
> Update the bindings to allow for generic regulator nodes instead of
> device-specific node names.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes
2022-11-21 10:27 ` Krzysztof Kozlowski
@ 2022-11-22 11:41 ` Krzysztof Kozlowski
2022-11-22 16:44 ` Melody Olvera
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-22 11:41 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Abel Vesa
On 21/11/2022 11:27, Krzysztof Kozlowski wrote:
> On 18/11/2022 19:25, Melody Olvera wrote:
>> Update the bindings to allow for generic regulator nodes instead of
>> device-specific node names.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Unreviewed, because this should include also SM8550, otherwise a new
patch will follow it immediately, which is not necessary.
On SM8550 the apps_rsc node has up to 6 PMICs, so it should be instead:
'^regulators(-[0-9])?$':
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes
2022-11-22 11:41 ` Krzysztof Kozlowski
@ 2022-11-22 16:44 ` Melody Olvera
0 siblings, 0 replies; 4+ messages in thread
From: Melody Olvera @ 2022-11-22 16:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Abel Vesa
On 11/22/2022 5:41 AM, Krzysztof Kozlowski wrote:
> On 21/11/2022 11:27, Krzysztof Kozlowski wrote:
>> On 18/11/2022 19:25, Melody Olvera wrote:
>>> Update the bindings to allow for generic regulator nodes instead of
>>> device-specific node names.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Unreviewed, because this should include also SM8550, otherwise a new
> patch will follow it immediately, which is not necessary.
>
> On SM8550 the apps_rsc node has up to 6 PMICs, so it should be instead:
> '^regulators(-[0-9])?$':
Sure thing.
Thanks,
Melody
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-22 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-18 18:25 [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes Melody Olvera
2022-11-21 10:27 ` Krzysztof Kozlowski
2022-11-22 11:41 ` Krzysztof Kozlowski
2022-11-22 16:44 ` Melody Olvera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).