From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 466B1C433EF for ; Fri, 10 Jun 2022 10:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348338AbiFJKMc (ORCPT ); Fri, 10 Jun 2022 06:12:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244063AbiFJKMa (ORCPT ); Fri, 10 Jun 2022 06:12:30 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62A67F74A1 for ; Fri, 10 Jun 2022 03:12:28 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id gl15so38666143ejb.4 for ; Fri, 10 Jun 2022 03:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=p/i2+crL1L43GiLXITg/vt3Q+0CXjjKGYscQg4ugrbw=; b=m3xGe026GsgzFKujBkFBMFTkrEv5ifTPmlL1JL3mqH3lHNTdAOtZJhFSrHdfi59Mhn Cp1pRHFfW4UfO9HOOz02ophvsooVXfRTrZcSj1TMpmtD+KKIfFjU5uLdIWfMJpEMtSTo u30C92w2vqpO6VTxPdDGd/nHD8zIZF4E8WCsj5KhxGfpnFUhVhodhQuiO6H8WS1UlytO l1JAP9X4Jb0hF2a1/U8nRhg76b27eKJ+L0R6o6xtEnUzSENi7jvrwLHgUMVPT4BKSMfZ g0EOQ8Qq7KTbFLuyZpzNZq31vaoGMSKhgD51YNEnjVsOeIIej0NyZr8X610KaMPPOAyu SYfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=p/i2+crL1L43GiLXITg/vt3Q+0CXjjKGYscQg4ugrbw=; b=S6i/jBBGabSt3y7dsA4CCbyBhVhFYVQt12EQdhoD6dNqLZ8Oa9jlPn0p+kfO2J91xh PLKwbljy+n/qh9fevVjDmTOLiJur8y80oZ+Q6srjXQ/ZZxmg+KMLPFiAlBYk42uzxSid hMH6XChL1xNbJDx54q0GQkQF0y8n13w2s9EXgZWDb8pRiytvYIHaZ3ry5h/8lulaXEJR qaoDwvqwHnVdrr6ELSmmp4jE8fuYutdqJmHLLSyA3Iz78T37K8sJzaTCGgK5y/VDob15 DsLJXbCbFXQlet5iUUsK17R9yuTXgA3myGc98sz02MWOgLT64LJd9AddjWjwKCV+SvmV mC7Q== X-Gm-Message-State: AOAM531Vomd+jhej9qrB5cHkt5FpMFmjrZYJkF1m8XPWHAC7D+ofMCXk XJrb0sX+PzVORRonADYvK41jRQ== X-Google-Smtp-Source: ABdhPJw0RDXtOcxvfPMtEiDAqOLDHPs1NI+Dt+TuY/tcMv7c9ex+vGJ+hFZbkNUXzQd0E/pMPrBTdg== X-Received: by 2002:a17:907:2d87:b0:711:dd41:1e72 with SMTP id gt7-20020a1709072d8700b00711dd411e72mr17399697ejc.742.1654855946970; Fri, 10 Jun 2022 03:12:26 -0700 (PDT) Received: from [192.168.0.202] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id x25-20020a170906b09900b006f52dbc192bsm12048266ejy.37.2022.06.10.03.12.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 03:12:26 -0700 (PDT) Message-ID: <410c5c97-8ff7-2303-5e19-d6053d3779dd@linaro.org> Date: Fri, 10 Jun 2022 12:12:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/3] dt-bindings: leds: skyworks,aat1290: convert to dtschema Content-Language: en-US To: Jacek Anaszewski , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20220607085343.72414-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/06/2022 22:28, Jacek Anaszewski wrote: > Hi Krzysztof, > > On 6/7/22 10:53, Krzysztof Kozlowski wrote: >> Convert the Skyworks Solutions, Inc. AAT1290 Current Regulator bindings >> to DT Schema. >> >> Signed-off-by: Krzysztof Kozlowski > [...] >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + // Ct = 220 nF, Rset = 160 kOhm >> + led-controller { >> + compatible = "skyworks,aat1290"; >> + flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>; >> + enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>; >> + >> + pinctrl-names = "default", "host", "isp"; >> + pinctrl-0 = <&camera_flash_host>; >> + pinctrl-1 = <&camera_flash_host>; >> + pinctrl-2 = <&camera_flash_isp>; >> + >> + led { >> + label = "flash"; > > Why are you adding label? It is deprecated, Eh, so it should be marked as deprecated:true, not just mentioned in the description (common.yaml). > but has the precedence over > new function and color for backwards compatibility, so it would make > those unused by the driver now. Please drop the label from this example. I synced the example with DTS, but I can drop it. No problem. Best regards, Krzysztof