From: Arnd Bergmann <arnd@arndb.de>
To: Vignesh R <vigneshr@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Evgeniy Polyakov <zbr@ioremap.net>,
Jonathan Corbet <corbet@lwn.net>, Paul Walmsley <paul@pwsan.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>, NeilBrown <neilb@suse.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] w1: masters: omap_hdq: Add support for 1-wire mode
Date: Fri, 27 Feb 2015 11:34:22 +0100 [thread overview]
Message-ID: <4111301.XAv3eRBo5S@wuerfel> (raw)
In-Reply-To: <54F04767.5070001@ti.com>
On Friday 27 February 2015 16:01:03 Vignesh R wrote:
> On Friday 27 February 2015 03:25 PM, Arnd Bergmann wrote:
> > On Friday 27 February 2015 14:54:17 Vignesh R wrote:
> >> +- compatible : should be "ti,omap3-1w" or "ti,am43xx-hdq"
> >>
> >
> > Do not use wildcards in the compatible string, use real part numbers
> > if you don't know the actual name of the device.
>
>
> The DT node for hdq on AM437x is already present in mainline
> (commit: 741cac5f00beb) and it declares compatibility as
> "ti,am43xx-hdq". Hence, I cannot change into anything different.
>
No, there is no driver using this device, and the binding was
not documented, so there is no problem in changing it: nobody
will notice a regression when it was never working before.
Arnd
next prev parent reply other threads:[~2015-02-27 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 9:24 [PATCH 1/2] ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W Vignesh R
2015-02-27 9:24 ` [PATCH 2/2] w1: masters: omap_hdq: Add support for 1-wire mode Vignesh R
2015-02-27 9:55 ` Arnd Bergmann
2015-02-27 10:31 ` Vignesh R
2015-02-27 10:34 ` Arnd Bergmann [this message]
2015-03-02 7:57 ` R, Vignesh
2015-03-01 23:09 ` [PATCH 1/2] ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W Paul Walmsley
2015-03-02 8:27 ` R, Vignesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4111301.XAv3eRBo5S@wuerfel \
--to=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=neilb@suse.de \
--cc=paul@pwsan.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).