From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E37B5C433EF for ; Sat, 2 Apr 2022 15:44:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357362AbiDBPqS (ORCPT ); Sat, 2 Apr 2022 11:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357350AbiDBPqG (ORCPT ); Sat, 2 Apr 2022 11:46:06 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 523503464C for ; Sat, 2 Apr 2022 08:44:12 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id g20so6208507edw.6 for ; Sat, 02 Apr 2022 08:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=KZ8/fEAK8gL6LZf1WUUUrVlQCOQtgCe3PxNJlYV+zLQ=; b=MfoUHg62C9zk6zb6ueTF1mLsAKxV8QDuTMoAWqMD6o1v0e3w5nAK6/9uvgHm66VbxM avejGNV4Lc/W3xweAqk8X2jbcvY5Gh3YSmNbKUZLo9GU+u1lLdaIcs7mu+CUX+6/JYRI MRzwWN3qndxpLEbVD00PLvfIy1wnW8D/aJ9RlBaIYBoJ326rOx2dCrJ2fyFfFMifOKi1 HrK0qg02dDM89aZGh9x5bEZlgS0e9cipFT09BT8IpoqyOy8aRX3Eyk5xU5zqtmfpM7Fv 0ZICKl+PkKvPmseQQO0BTHOePdNVV05erEeCpdtt4oAOQTyYkWn7zjB+xtluVr7nOUJl yC+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KZ8/fEAK8gL6LZf1WUUUrVlQCOQtgCe3PxNJlYV+zLQ=; b=jnNvHUOdgUIlF+aaDOFbtWOsfkaE3bKnffwym4Q+ddmUbUra4Tgz5r2TDeEs0gUz+7 lPo/gaJ5GjEv7u6qOvjrIeNqPEK+IQj7dmnIS2/VFXtNbeH7qL+QCJrJlZG15RC6589B JaWfM3bNI5V+gmfHigX8UC5Qk/XtqfZXcXg9oJTTFaWo5wstu3rDYLgI0e3xKw7/HNaO 1f2M5gvrszX/sPpCxlpOiiRDfq6bM564ovISSUI78jPYMOLONeTocZjl6CYDFUsppfAt etR6eUY+Updy4qxt6af3yGS9C8u4I47dA/rTwVegpJrW7NMvUIgWYYoSUYRS6khvckbw 7Eiw== X-Gm-Message-State: AOAM532KE82l7drA9JEagHuX76YPzWw9mILYhQPt5UUDq7fVsc60OwBm 9qeYAgDNeG235VGcN2q42p1MhA== X-Google-Smtp-Source: ABdhPJwNHUoqs/nTqT9b4RQ3iE3pAQn7Q5456kJUCETm6XcoXqoTI19RlOdwMsCodSspxOC/dhnzIw== X-Received: by 2002:a05:6402:1749:b0:419:325b:f8c with SMTP id v9-20020a056402174900b00419325b0f8cmr26045752edx.386.1648914250882; Sat, 02 Apr 2022 08:44:10 -0700 (PDT) Received: from [192.168.0.33] (cpc78119-cwma10-2-0-cust590.7-3.cable.virginm.net. [81.96.50.79]) by smtp.gmail.com with ESMTPSA id sd7-20020a1709076e0700b006e015549bdfsm2162441ejc.53.2022.04.02.08.44.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Apr 2022 08:44:10 -0700 (PDT) Message-ID: <4111496f-c26b-ee89-15ed-6902e58fde5f@linaro.org> Date: Sat, 2 Apr 2022 16:44:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings for smb2 driver Content-Language: en-US To: Sebastian Reichel Cc: Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Amit Pundir , Sumit Semwal References: <20220401202643.877609-1-caleb.connolly@linaro.org> <20220401202643.877609-7-caleb.connolly@linaro.org> <20220401230356.w7obr3nxl6673mig@mercury.elektranox.org> From: Caleb Connolly In-Reply-To: <20220401230356.w7obr3nxl6673mig@mercury.elektranox.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/04/2022 00:03, Sebastian Reichel wrote: > Hi, > > On Fri, Apr 01, 2022 at 09:26:43PM +0100, Caleb Connolly wrote: >> Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger >> drivers. >> >> Signed-off-by: Caleb Connolly >> --- >> .../bindings/power/supply/qcom,smb2.yaml | 68 +++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml >> >> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml b/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml >> new file mode 100644 >> index 000000000000..1bea1fef78b8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml >> @@ -0,0 +1,68 @@ >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/supply/qcom,smb2.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm PMI8998/PM660 Switch-Mode Battery Charger "2" >> + >> +maintainers: >> + - Caleb Connolly >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,pmi8998-smb2 >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + items: >> + - description: usb plugin >> + >> + interrupt-names: >> + items: >> + - const: usb-plugin >> + >> + io-channels: >> + items: >> + - description: USB in current in uA >> + - description: USB in voltage in uV >> + >> + io-channel-names: >> + items: >> + - const: usbin_i >> + - const: usbin_v > > Is there a good reason to use usbin_ instead of usb_in_? These are the channel names exposed by the RRADC driver, so they would have to be changed there. > > -- Sebastian > >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - interrupt-names >> + - io-channels >> + - io-channel-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + pmic { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + #interrupt-cells = <4>; >> + >> + smb2@1000 { >> + compatible = "qcom,pmi8998-smb2"; >> + reg = <0x1000>; >> + >> + interrupts = <0x2 0x13 0x4 IRQ_TYPE_EDGE_BOTH>; >> + interrupt-names = "usb-plugin"; >> + >> + io-channels = <&pmi8998_rradc 3>, >> + <&pmi8998_rradc 4>; >> + io-channel-names = "usbin_i", >> + "usbin_v"; >> + }; >> + }; >> -- >> 2.35.1 >> -- Kind Regards, Caleb (they/them)