Re: [PATCH v1 2/9] dt-bindings: arm: add Black Sesame Technologies (bst) SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/05/2025 10:54, Albert Yang wrote:
> Add device tree bindings for Black Sesame Technologies Arm SoC,
> it consists several SoC models like C1200, etc.
> 
> Signed-off-by: Ge Gordon <gordon.ge@bst.ai>
> Signed-off-by: Albert Yang <yangzh0906@thundersoft.com>
> ---
>  .../devicetree/bindings/arm/bst.yaml          | 34 +++++++++++++++++++

... so now I see patch 2/9 disconnected from the rest.

Just use b4 for submitting and you will avoid several easy mistakes.


>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/bst.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/bst.yaml b/Documentation/devicetree/bindings/arm/bst.yaml
> new file mode 100644
> index 000000000000..e21a37130cef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bst.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/bst.yaml#

Missing vendor prefix.... unless 1/9 was there and will come sometime in
the future. :/

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: BST platforms
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  Black Sesame Technologies (BST) is a semiconductor company that produces
> +  automotive-grade system-on-chips (SoCs) for intelligent driving, focusing
> +  on computer vision and AI capabilities. The BST C1200 family includes SoCs
> +  for ADAS (Advanced Driver Assistance Systems) and autonomous driving applications.
> +
> +maintainers:
> +  - Ge Gordon <gordon.ge@bst.ai>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: BST C1200 family platforms
> +        items:
> +          - const: bst,c1200

Drop this entry. You cannot have SoC aloone.



Best regards,
Krzysztof