From: Michael Walle <michael@walle.cc>
To: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
arnd@arndb.de, alexandre.belloni@bootlin.com, olof@lixom.net,
soc@kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
Manohar.Puri@microchip.com
Subject: Re: [PATCH v7] ARM: dts: add DT for lan966 SoC and 2-port board pcb8291
Date: Thu, 24 Feb 2022 15:55:05 +0100 [thread overview]
Message-ID: <413b29b8a2e7a73561f942d4b7c78b9b@walle.cc> (raw)
In-Reply-To: <85566f97-dcfc-f477-1ebb-5cac955b791a@microchip.com>
Hi,
Am 2022-02-24 15:51, schrieb Nicolas Ferre:
>>> +/ {
>>> + model = "Microchip LAN966 family SoC";
>>> + compatible = "microchip,lan966";
>>
>> As mentioned earlier, this isn't a documented compatible string. So,
>> I guess without overwriting this in the board dts it will throw an
>> error with the dt schema validator. OTOH, there are many dtsi files
>> in arch/arm/boot/dts/ doing this. I don't know what is correct here.
>
> I see it documented here:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/atmel-at91.yaml#n165
>
> Isn't it what is expected?
That only documents
compatible = "microchip,lan9662-pcb8291", "microchip,lan9662",
"microchip,lan966";
But not the one above.
>
>> Everthing else looks good.
>
> Thanks a lot for your reviews.
>
>> Reviewed-by: Michael Walle <michael@walle.cc>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> I'm queuing it to at91-dt branch for reaching arm-soc in 5.18 merge
> window.
Nice, then I'm good to go for my patches on top of this :)
-michael
next prev parent reply other threads:[~2022-02-24 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 8:08 [PATCH v7] ARM: dts: add DT for lan966 SoC and 2-port board pcb8291 Kavyasree Kotagiri
2022-02-21 9:10 ` Michael Walle
2022-02-24 14:51 ` Nicolas Ferre
2022-02-24 14:55 ` Michael Walle [this message]
2022-02-25 10:26 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413b29b8a2e7a73561f942d4b7c78b9b@walle.cc \
--to=michael@walle.cc \
--cc=Manohar.Puri@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kavyasree.kotagiri@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).