From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks Date: Thu, 18 Jul 2019 19:34:21 +0300 Message-ID: <4141181d-7162-0321-71b6-33abf11f631c@gmail.com> References: <093462f3-8c6d-d084-9822-ae4eff041c64@nvidia.com> <20190717093317.70fefb27@dimatab> <6e73dcee-6e24-b646-97a4-4b34aedd231d@nvidia.com> <16f8b146-2581-a842-4997-53ab05b62c70@gmail.com> <71272e9a-0f2a-c20d-6532-7e9057ad985c@gmail.com> <78fd19b9-b652-8ac3-1f57-3b4adadee03f@nvidia.com> <351a07d4-ba90-4793-129b-b1a733f95531@nvidia.com> <9271ae75-5663-e26e-df26-57cba94dab75@nvidia.com> <7ae3df9a-c0e9-cf71-8e90-4284db8df82f@nvidia.com> <46b55527-da5d-c0b7-1c14-43b5c6d49dfa@nvidia.com> <2de9a608-cf38-f56c-b192-7ffed65092f8@nvidia.com> <5eedd224-77b0-1fc9-4e5e-d884b41a64ed@nvidia.com> <89f23878-d4b2-2305-03e5-8a3e781c2b02@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sowjanya Komatineni , sboyd@kernel.org, Michael Turquette Cc: Peter De Schrijver , Joseph Lo , thierry.reding@gmail.com, jonathanh@nvidia.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linus.walleij@linaro.org, stefan@agner.ch, mark.rutland@arm.com, pgaikwad@nvidia.com, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, jckuo@nvidia.com, talho@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, mperttunen@nvidia.com, spatra@nvidia.com, robh+dt@kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org 18.07.2019 4:15, Sowjanya Komatineni пишет: [snip] >>> Please try to fix all missing dependencies and orderings. >> >> Peter, >> >> dfllCPU_OUT is the first one to go thru restore when >> clk_restore_context traverses thru the list. >> >> dfllCPU_OUT has dependency on DFLL_ref and DFLL_SOC but this >> dependency is unknown to clock-tree. >> >> We can add DFLL_REF and DFLL_SOC as parents to dfllCPU_OUT during >> register so dfllCPU_OUT save/restore happens after their parents are >> restored. >> >> But DFLL needs both of these to be restored before DFLLCPU_Out and as >> DFLL_SOC restore always happens after the REF, thinking to add >> DFLL_SOC as parent to dfllCPU_OUT so save/restore follows after their >> dependencies. >> >> Please comment. >> > Did quick try and I see by adding dfll-soc as parent to dfllCPU_OUT, its > in proper order after all its dependencies. > > Can now add dfll save/restore to do dfll reinit during restore.. > If dfllCPU_OUT can work properly with dfll-soc being disabled, then this kind of dependency isn't very correct and just papers over the real problem, which is that there should be a way for CCF to specify multiple dependencies for the clock or the reverse ordering should be used for the restoring.