From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E8D2C77B73 for ; Tue, 2 May 2023 11:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233905AbjEBLNQ (ORCPT ); Tue, 2 May 2023 07:13:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233828AbjEBLNP (ORCPT ); Tue, 2 May 2023 07:13:15 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 271C949C5 for ; Tue, 2 May 2023 04:13:13 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2a8b766322bso34777311fa.1 for ; Tue, 02 May 2023 04:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683025991; x=1685617991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UnVYWj5xPWY/m7D8adizrBPOFdgKen1k/+SyuHo7cjg=; b=LKBhk3BmOlhQyCFb2X3jjwO0SaGDqF9aDLFBy3Joo0y4eaPOB2i4wUJ+VxIY48WOWh SrT97QjDE0BL7mvp4IO1DiM3doN4fsI8LdicHcP4zzsRXe/qNMguEdzMSY2ShG0CCnI4 VGf77M06C9umz2EB+PKxL5o1To8k/3XmFy5AyW8hrAiVQUeJHi0H575pouCQAI+bCXaP R06sSJ+EYUNROmtsHMluk3tyqrdrq6zHgS4k937qLfh6PAdgeaCn/8OaajbxSFqm93oY GDtlc3sUw027gAOkoBVkygPQicL3wzo3cGXoT4N4ifz5CciJWHYYKXs3sKAV6ylGpWV9 05kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683025991; x=1685617991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UnVYWj5xPWY/m7D8adizrBPOFdgKen1k/+SyuHo7cjg=; b=Yx1axY9BJKQFP/1BcXLY5gh8t7BHw+vabmL7XCc5F/OlDlnZ1S2vWgLnn6sKfuvo5I 2eHJsix/Duhv/toppc4jyNucqe/1MvrVbOe7o1M03HIlEiBwwoqVGN/RRXw/5LWnZ/E8 uufioWl3wcd7TkX/huyuV5IJjMfxXSLJ6mieBZF3dMEg0oCUnuyoEYZSY/JV3cQTg4Gm 0RtiQ/Spq2pLuA4IsQxvN1YiGCfc/Qw3a8vzXovVYYS4lkeqUPb1FfehqJ+Rm93pHW+S HF3d3RloSQ0w45rDmEAS+pN2nVNW7sr2YdEctUOcr6ppjcA8MpEA0vk924gDMo3gfocI 4F0w== X-Gm-Message-State: AC+VfDxDob+0HxFJ9/P1rKu+7xYqF3fVlLLK2C5macYeZjOAiZmM3k4Q EwLGwjopgtgDpujQyYQhCffp1w== X-Google-Smtp-Source: ACHHUZ4vYM0BPN8EjS0h4Heha5KHPG6RO9skTE1BEOMUqjpMEHbkGBzmP42J6P845qSlP7nfD+cUwA== X-Received: by 2002:a05:651c:154:b0:2a7:76ab:c4c with SMTP id c20-20020a05651c015400b002a776ab0c4cmr4818689ljd.8.1683025991214; Tue, 02 May 2023 04:13:11 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id l16-20020ac25550000000b004edc16dbdfasm5280650lfk.119.2023.05.02.04.13.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 04:13:10 -0700 (PDT) Message-ID: <41581143-2caa-bac1-479c-c8feaf2de1b9@linaro.org> Date: Tue, 2 May 2023 13:13:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v6 12/13] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Content-Language: en-US To: Bryan O'Donoghue , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, luca.weiss@fairphone.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: caleb.connolly@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230501121111.1058190-1-bryan.odonoghue@linaro.org> <20230501121111.1058190-13-bryan.odonoghue@linaro.org> <109dc9fe-5ca7-1a98-3222-8c2297f4e8ce@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2.05.2023 13:03, Bryan O'Donoghue wrote: > On 02/05/2023 12:00, Konrad Dybcio wrote: >>> +            #address-cells = <1>; >>> +            #size-cells = <0>; >>> + >>> +            port@0 { >>> +                reg = <0>; >>> +                pm8150b_role_switch_out: endpoint { >> Similarly to the QMPPHY, the port definition can be moved to >> the common node in the SoC DTSI > > But then the connector would have to be defined in the SoC dtsi and not all derivatives of SoC can be assumed to have a usb-c-connector. Not quite! You can define an empty endpoint (like we do with DSI<->panel ones) and fill it in on the device side. Konrad > > grep "usb-c-connector" arch/arm64/boot/dts/qcom/* > > --- > bod