From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0155C433FE for ; Fri, 11 Feb 2022 07:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347829AbiBKHz2 (ORCPT ); Fri, 11 Feb 2022 02:55:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347825AbiBKHz0 (ORCPT ); Fri, 11 Feb 2022 02:55:26 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F28FBD3 for ; Thu, 10 Feb 2022 23:55:25 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 7941D402C2 for ; Fri, 11 Feb 2022 07:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644566124; bh=MQDLOkOWyhrokLh/q2SGFaaeI8uLaofwFWx6RTobIHo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q5txqrh/AygU5OXv5RAy2QohTn+iGQHii+zCRCGZle1sfks23/ZZINzJa+CpB0R0r vLogFDVQZlqX8x35As2OResdEy4F/11acQf34MCv3iTAqkdIkAF+xhEBIPD+BmCZ5i loVFaXBatfgZG9z6DRbGiyam1uqi70610P9YzrKlSr24LZoPwEVanoTAkuCWuKlQ/E s8zv+q6pNX1WXxfYVCpirOCJW2dZf8V+EVv1+qzCKR2d3FAn8KJRXJt6r78TRyR9zv AHKKqUmMa6pZXoSI5t9P7+cj8pYxP5EQiSr6GO1rci+JscmCs1jxE8x19kc5T97zzC OctIOUJXMNNfw== Received: by mail-ed1-f70.google.com with SMTP id j10-20020a05640211ca00b004090fd8a936so236966edw.23 for ; Thu, 10 Feb 2022 23:55:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MQDLOkOWyhrokLh/q2SGFaaeI8uLaofwFWx6RTobIHo=; b=bOja7Hbc+FRmrep5BrBXOdTgEfuCY80SACVEW/OoEzosK5raSv9/qephcxdXm33lhQ +wvuye8x0dXxdTq463cL3z5f3wxryWKVkNTbQxFMUMmeRdfyR2zDeIGp7K3laajyr8+U b51bFaqqSCZjxexs+3c7ijLSLlVXknR0/KwGwft9xtx7yKCFkNBDl/C1ej0Mkm3C2i7o piHShtXekokXbwmuqD988oAi42ogVmU7KASu9UPU/WHiV0dSazcxHWuqRISqHeWjLis2 fULwV2/AHMKiyDloVNu2fJciuBmmeiah0Rgo3qUr4bYV3tfM7FDs1EiRSZIsQly1K9uu qMKw== X-Gm-Message-State: AOAM5334KytMLz9r7T9678jdK1hXjtpVEFiaRfQCRCwQELIQd0AQgVOz a+/T9SldBPGBRNOnOgSj0d3DnSWvt3uFP8vtQTsddR+Fyi6HF6jLuMyH7iQN1XfmLF5KbjQYHed PZBPhzfe1QYCafpzkwNJF0BJVCGJMNvav5psF+2g= X-Received: by 2002:aa7:c9cf:: with SMTP id i15mr564745edt.115.1644566122416; Thu, 10 Feb 2022 23:55:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxS2mWZknsLENYbOC1IbYB+o7Y3nGS6XqPGFBYc0O9YHzbfrvYAJgRo8QBScWMffqbdP1Uo2A== X-Received: by 2002:aa7:c9cf:: with SMTP id i15mr564724edt.115.1644566122272; Thu, 10 Feb 2022 23:55:22 -0800 (PST) Received: from [192.168.0.99] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id 27sm157401eji.66.2022.02.10.23.55.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 23:55:21 -0800 (PST) Message-ID: <416c07c1-c563-c72c-edfd-ae14ecf0cf13@canonical.com> Date: Fri, 11 Feb 2022 08:55:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 3/9] dt-bindings: memory: lpddr2: Add revision-id properties Content-Language: en-US To: Dmitry Osipenko , Julius Werner Cc: Rob Herring , linux-tegra@vger.kernel.org, Rob Herring , Jonathan Hunter , devicetree@vger.kernel.org, LKML , Thierry Reding References: <20211006224659.21434-1-digetx@gmail.com> <20211006224659.21434-4-digetx@gmail.com> <6568fd31-113f-1581-4eff-45a4a1eb4e5d@canonical.com> <20220211021739.14f3614c@dimatab> From: Krzysztof Kozlowski In-Reply-To: <20220211021739.14f3614c@dimatab> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/02/2022 00:17, Dmitry Osipenko wrote: > В Wed, 9 Feb 2022 16:32:25 -0800 > Julius Werner пишет: > > >>> I made each LPDDR2 revision-id property to correspond to a >>> dedicated MR of LPDDR, which feels okay to me to since it matches >>> h/w. >> >> I'm not super married to my solution, so if that makes things easier >> we can standardize on the two-property version as well. I mostly >> designed it my way because I thought we may one day also want to do >> something like this for the 8-byte LPDDR5 serial-id, and then it would >> get kinda cumbersome to have serial-id1 through serial-id8 all as >> separate properties. But that's also a bridge we can cross when we get >> there. >> >> My use case is in a position where we could still change this now >> without requiring backwards-compatibility. Krzysztof, would you be >> okay if I instead changed the "jedec,lpddr3" to the same thing >> "jedec,lpddr2" does -- seeing as the original patch was from me, my >> use case could handle the switch, there has never been any actual >> kernel code using the property, and it seems very unlikely that anyone >> else has silently started using the same thing in the time it's been >> in the tree? Or do we also need to go the official deprecation route >> for that? > > If you're going to use multiple cells for other properties, then indeed > will be better to keep it consistent. Yeah, LPDDR5 is a nice argument. Let's go with the array approach (so LPDDR3). Julius, Official deprecation is needed, because the property might be used also in other projects or customers. But this is not a big deal - we will just keep old property for some time. Will you send a patch for it? Best regards, Krzysztof