From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902C2C2D0F0 for ; Wed, 1 Apr 2020 13:10:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6773F20776 for ; Wed, 1 Apr 2020 13:10:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mm-sol.com header.i=@mm-sol.com header.b="Qhd9G2/B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732296AbgDANKu (ORCPT ); Wed, 1 Apr 2020 09:10:50 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:33824 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732252AbgDANKu (ORCPT ); Wed, 1 Apr 2020 09:10:50 -0400 X-Greylist: delayed 560 seconds by postgrey-1.27 at vger.kernel.org; Wed, 01 Apr 2020 09:10:49 EDT Received: from [192.168.1.3] (212-5-158-187.ip.btc-net.bg [212.5.158.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by extserv.mm-sol.com (Postfix) with ESMTPSA id 46D27CFAB; Wed, 1 Apr 2020 16:01:28 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mm-sol.com; s=201706; t=1585746088; bh=zOxr38VY0D/4MvUtAz2wio+gKJ7DGco1NKhyuLfJmn8=; h=Subject:To:Cc:From:Date:From; b=Qhd9G2/BG12qd1SDazQPmx/WmHsy9p48aY/i3sjh8ZIHSkbpC5XWyUwla8MDCe2S1 qG+nuRYhknQUP+HGtMu5LAq/sOu5YKLtaRHxABuWzyPzaWTXD4XwEzEj7dKVLEBbCf xBri1yb9Ai+wCyVXP/CaF+u+bMbgGknITT3QxXq1Y1fcY7R4Jw9sIOtPuo2FwqIpcA DL6lcJxub/XtnH5n1dwBz5jlzahrpsyjNR3QyIdEvnrLLB+2KzcllP5PXqtCl1AlpH XOHRsXt+++1YW1mSVy49pxGSO3qzriGhIJFg27paMHABECqRWJyr1DqaszAXbE++Zf 53q9cL4CvjVSQ== Subject: Re: [PATCH 01/12] pcie: qcom: add missing ipq806x clocks in pcie driver To: Ansuel Smith Cc: Sham Muthayyan , Andy Gross , Bjorn Andersson , Bjorn Helgaas , Rob Herring , Mark Rutland , Lorenzo Pieralisi , Andrew Murray , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200320183455.21311-1-ansuelsmth@gmail.com> From: Stanimir Varbanov Message-ID: <416ed5fa-4e22-68cc-1c80-be720e72ad55@mm-sol.com> Date: Wed, 1 Apr 2020 16:01:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200320183455.21311-1-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Ansuel, As Bjorn already mentioned please make cover-letter in next version of the patchset so that we know what is the purpose of the patches. I've the impression that you want to use pcie-qcom platform driver as an endpoint, am I wrong? I'll review the patches these days. On 3/20/20 8:34 PM, Ansuel Smith wrote: > Aux and Ref clk are missing in pcie qcom driver. > Add support in the driver to fix pcie inizialization > in ipq806x > > Signed-off-by: Sham Muthayyan > Signed-off-by: Ansuel Smith > --- > drivers/pci/controller/dwc/pcie-qcom.c | 38 ++++++++++++++++++++++---- > 1 file changed, 33 insertions(+), 5 deletions(-) -- regards, Stan