From: Heiko Stuebner <heiko@sntech.de>
To: Emil Renner Berthing <kernel@esmil.dk>,
Doug Anderson <dianders@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Brian Norris <briannorris@chromium.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: enable touchpad button for rk3399-gru-kevin
Date: Tue, 10 Oct 2017 11:33:49 +0200 [thread overview]
Message-ID: <4174027.Z5MyPRUDcj@phil> (raw)
In-Reply-To: <20171009184028.11829-1-kernel@esmil.dk>
Hi Emil,
Am Montag, 9. Oktober 2017, 20:40:28 CEST schrieb Emil Renner Berthing:
> Adding the linux,gpio-keymap entry also has
> the side-effect of making the driver register
> the touchpad as a touchpad rather than another
> touchscreen.
>
> The index for BTN_LEFT was found by trial and error.
>
> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
looks good to me. I'll just give the ChromeOS people a chance to
respond before applying [maybe they can even tell what the other
keys are :-) ]
Heiko
> ---
> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> index 5c8621766908..1c58d12551f5 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> @@ -278,6 +278,10 @@ ap_i2c_dig: &i2c2 {
> pinctrl-0 = <&trackpad_int_l>;
> interrupt-parent = <&gpio1>;
> interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
> + linux,gpio-keymap = <KEY_RESERVED
> + KEY_RESERVED
> + KEY_RESERVED
> + BTN_LEFT>;
> wakeup-source;
> };
> };
>
next prev parent reply other threads:[~2017-10-10 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 18:40 [PATCH] arm64: dts: rockchip: enable touchpad button for rk3399-gru-kevin Emil Renner Berthing
2017-10-10 9:33 ` Heiko Stuebner [this message]
2017-10-10 11:04 ` Emil Renner Berthing
[not found] ` <CANBLGcx187QrX3pgUAjvBmPbyJsX7ZiYdWXhamM-atEe+Mqe3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-10 17:03 ` Brian Norris
2017-10-10 17:25 ` Dmitry Torokhov
2017-10-14 19:14 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4174027.Z5MyPRUDcj@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kernel@esmil.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).