From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66570C433EF for ; Sat, 11 Jun 2022 13:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232552AbiFKNuY (ORCPT ); Sat, 11 Jun 2022 09:50:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231378AbiFKNuX (ORCPT ); Sat, 11 Jun 2022 09:50:23 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B3DD5EBF0; Sat, 11 Jun 2022 06:50:20 -0700 (PDT) Received: from p508fd9f0.dip0.t-ipconnect.de ([80.143.217.240] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o01VC-0004TJ-AU; Sat, 11 Jun 2022 15:50:10 +0200 From: Heiko Stuebner To: Rob Herring , Krzysztof Kozlowski , Michael Riesch , Peter Geis Cc: devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List Subject: Re: [PATCH] arm64: dts: rockchip: Fix SoQuartz CM4IO usb Date: Sat, 11 Jun 2022 15:50:08 +0200 Message-ID: <4178848.3VsfAaAtOV@phil> In-Reply-To: References: <20220610132601.160088-1-pgwipeout@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Freitag, 10. Juni 2022, 16:44:23 CEST schrieb Peter Geis: > On Fri, Jun 10, 2022 at 9:26 AM Peter Geis wrote: > > > > The SoQuartz CM4-IO should support otg mode, however it currently > > defaults to device mode when otg is enabled. Force it to host mode to > > retain the previous behavior. > > It would seem the role-switch issue is more widespread than originally > thought, affecting other boards where automatic control should work. > Please hold this patch while I investigate further. ok! I guess this also applies to "arm64: dts: rockchip: Fix Quartz64-A dwc3 otg port behavior"? Heiko > > > > Fixes: bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x") > > > > Signed-off-by: Peter Geis > > --- > > arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts > > index e00568a6be5c..56764fae9f9d 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts > > @@ -169,6 +169,7 @@ &usb2phy0_otg { > > }; > > > > &usb_host0_xhci { > > + dr_mode = "host"; > > status = "okay"; > > }; > > > > -- > > 2.25.1 > > >