From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Simon Horman <horms@verge.net.au>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231
Date: Tue, 19 Nov 2013 13:52:27 +0100 [thread overview]
Message-ID: <4182325.G3k8SsHnK4@avalon> (raw)
In-Reply-To: <20131119025629.GA14794@verge.net.au>
Hi Simon,
On Tuesday 19 November 2013 11:56:29 Simon Horman wrote:
> On Sat, Nov 09, 2013 at 01:23:59PM +0100, Laurent Pinchart wrote:
> > The device is configured to generate an active-low interrupt signal that
> > needs to be acknowledged by the host. Configure the IRQ to trigger on
> > low level.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> > b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts index
> > aef425f..04e9d49 100644
> > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> > @@ -95,7 +95,7 @@
> > compatible = "sitronix,st1232";
> > reg = <0x55>;
> > interrupt-parent = <&irqpin1>;
> > - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */
> > + interrupts = <2 IRQ_TYPE_LOW_LEVEL>;
>
> I believe this should be IRQ_TYPE_LEVEL_LOW.
>
> I have dequeued this patch for now.
My bad, I've tested level low trigger first, then falling edge trigger, and
switched back to low level without recompiling the patch. Sorry about that,
I'll resend now.
> > pinctrl-0 = <&st1232_pins>;
> > pinctrl-names = "default";
> > gpios = <&pfc 166 GPIO_ACTIVE_LOW>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-11-19 12:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 12:23 [PATCH 0/7] ARM: shmobile: Use interrupt macros in DT files Laurent Pinchart
2013-11-09 12:23 ` [PATCH 1/7] ARM: shmobile: Use #include in device tree sources Laurent Pinchart
2013-11-09 12:23 ` [PATCH 2/7] ARM: shmobile: Use interrupt macros in SoC DT files Laurent Pinchart
2013-11-19 1:38 ` Simon Horman
2013-11-19 1:50 ` Laurent Pinchart
2013-11-19 2:36 ` Simon Horman
2013-11-19 2:18 ` [PATCH v2 " Laurent Pinchart
2013-11-19 2:40 ` Simon Horman
2013-11-09 12:23 ` [PATCH 3/7] ARM: shmobile: Use interrupt macros in board " Laurent Pinchart
2013-11-09 12:23 ` [PATCH 4/7] ARM: shmobile: marzen-reference: Use falling edge IRQ for LAN9221 Laurent Pinchart
2013-11-09 12:23 ` [PATCH 5/7] ARM: shmobile: bockw-reference: " Laurent Pinchart
2013-11-09 12:23 ` [PATCH 6/7] ARM: shmobile: kzm9g-reference: " Laurent Pinchart
2013-11-09 12:23 ` [PATCH 7/7] ARM: shmobile: armadillo-reference: Use low level IRQ for ST1231 Laurent Pinchart
2013-11-19 1:42 ` Simon Horman
2013-11-19 2:56 ` Simon Horman
2013-11-19 12:52 ` Laurent Pinchart [this message]
2013-11-19 12:59 ` [PATCH v2 " Laurent Pinchart
2013-11-21 5:02 ` Simon Horman
2013-11-18 8:42 ` [PATCH 0/7] ARM: shmobile: Use interrupt macros in DT files Simon Horman
2013-11-18 11:18 ` Laurent Pinchart
2013-11-19 1:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4182325.G3k8SsHnK4@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox