From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E6FC433EF for ; Thu, 14 Apr 2022 22:32:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238663AbiDNWfQ (ORCPT ); Thu, 14 Apr 2022 18:35:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237591AbiDNWfO (ORCPT ); Thu, 14 Apr 2022 18:35:14 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B1DBC55AD for ; Thu, 14 Apr 2022 15:32:49 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id n40-20020a05600c3ba800b0038ff1939b16so2900785wms.2 for ; Thu, 14 Apr 2022 15:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UFIRxq0l3P41n43NuZnwMq/zIHx91U9NMxsc5GFePPs=; b=JPwhBYp2b+cnRmynszCgl0OaB2hunKoai93i2UDWaYiga4+NCdpDxUCSlx7aQzouR7 juoTxGSBLReDDPh8UXhDhXg16n9t7x2BFTBmJUn9HTa8EMuo5Z/h6rdDz9/jnajch+Jw 9oyc4OU9pC9DYsJbr1nTRI+98MtWzHuQns3vZ9zq6G/pu8fMTrvdr0CSLlAgB+Wo7C4U O9ww4cJY9gjF0Cihs4rW7bxfWQ2O6jDjf3vnfG4G98UBKoPBxJSiAWkhR/VcijcEH4H/ xfIIsPxDJChffZz+TN+TY4fZWQDwfxDp026qNa4AiveDOaurHaLOqojxrHFJMvJ04BP6 6c5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UFIRxq0l3P41n43NuZnwMq/zIHx91U9NMxsc5GFePPs=; b=Uk1ZSgt2C8PAVKffNg4X1C+NiL/PITa4K7Q9oRlCyDpKH8YJx7K2RqMYtsq+I+156U pYlNHkCm6SlY9iDD/ZGar9961I4qwTrPteN2VpzNokbYA+FcvO8Y7msibx4I80jVnpfl 92esJzL4+pJY6YxNXafwez/1+fAq5zdIvQvcf0r8h1OYY2a0aPCbOEV4XRRCSLMJq4mE tlQ/jUfpxWRO3hi5oKhExZsqQ/nnAi0aVqAdQWntUl7rw/kPLvaF3QKS7q7ZMZsaFFw0 L47n+tkMGO02og/9kHEFieThWXDLq9gMlDtvUZsOVQB8zrWzwEY3Rz5MR1UfBUXXKsi2 nvQw== X-Gm-Message-State: AOAM531YCAv3HnqNuijNBOZlJvbn+9GoB2VYPHot0+d85gK/4EST4/Qj k+OaLZjyFoxs4/kpJztYXYR1yw== X-Google-Smtp-Source: ABdhPJx+N5gTLVs1VE+DLX1v1GF3Advq9KuGMx9sOv/+jvTlg7K62Im1ejIbcnITDVZcf6wKSJ/Kew== X-Received: by 2002:a05:600c:4ec6:b0:38e:c0bf:882e with SMTP id g6-20020a05600c4ec600b0038ec0bf882emr605983wmq.50.1649975567490; Thu, 14 Apr 2022 15:32:47 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id u7-20020a5d6da7000000b00203d9d1875bsm3098816wrs.73.2022.04.14.15.32.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 15:32:46 -0700 (PDT) Message-ID: <418b73f1-a5b9-ce07-1fc1-736107f36c41@linaro.org> Date: Thu, 14 Apr 2022 23:32:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 2/2] media: i2c: imx412: Add bulk regulator support Content-Language: en-US To: Sakari Ailus Cc: paul.j.murphy@intel.com, daniele.alessandrelli@intel.com, mchehab@kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, robert.foss@linaro.org, hfink@snap.com, jgrahsl@snap.com, dmitry.baryshkov@linaro.org, vladimir.zapolskiy@linaro.org References: <20220414124505.1329295-1-bryan.odonoghue@linaro.org> <20220414124505.1329295-3-bryan.odonoghue@linaro.org> <39cae749-67ef-13d7-2648-01c6e9603887@linaro.org> <831e3857-9ee7-c760-ef2e-3b235b57b907@linaro.org> <784b5caf-1e1a-e57c-126e-4b28bc6ff7f8@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/04/2022 22:58, Sakari Ailus wrote: > It's still wrong and should be fixed. It seems there are no boards in the > DT source in the kernel using this sensor. These changes seem fine to me. > > I'm not really worried about ACPI: it's unlikely the GPIO is even declared > for the sensor, and instead is controlled in AML. There can of course be > bugs in ACPI tables, too... Hmm. OK well I'll add the GPIO patch in for V5 but with a putative guard in for ACPI, inverting the logic. We can always pull the guard if it turns out not be necessary. --- bod