From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] arm64: dts: qcom: sdx75-idp: Add regulator nodes
Date: Wed, 2 Aug 2023 14:49:56 +0200 [thread overview]
Message-ID: <41b9bbd2-e58f-810d-ad3b-715423ffe74b@linaro.org> (raw)
In-Reply-To: <1690970366-30982-9-git-send-email-quic_rohiagar@quicinc.com>
On 2.08.2023 11:59, Rohit Agarwal wrote:
> Add the regulators found on SDX75 IDP.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
[...]
> + vreg_s2b_1p224: smps2 {
Even though most RPMh devices use the schematic-like names, I think naming
the labels like pmicname_regname, e.g. pm8550_l2 would be easier to read..
(Bjorn, Krzysztof - opinions?)
On top of that, please add labels to all of the regulators you're
introducing to limit unnecessary diff in the future.
Konrad
next prev parent reply other threads:[~2023-08-02 12:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:59 [PATCH 0/8] Add pmics supported in Qualcomm's SDX75 platform Rohit Agarwal
2023-08-02 9:59 ` [PATCH 1/8] arm64: dts: qcom: sdx75: Add spmi node Rohit Agarwal
2023-08-02 12:40 ` Konrad Dybcio
2023-08-02 13:07 ` Rohit Agarwal
2023-08-02 9:59 ` [PATCH 2/8] arm64: dts: qcom: Add pinctrl gpio support for pm7250b Rohit Agarwal
2023-08-02 12:41 ` Konrad Dybcio
2023-08-02 9:59 ` [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi Rohit Agarwal
2023-08-02 12:42 ` Konrad Dybcio
2023-08-02 13:13 ` Rohit Agarwal
2023-08-02 13:14 ` Konrad Dybcio
2023-08-02 13:19 ` Rohit Agarwal
2023-08-03 5:06 ` Pavan Kondeti
2023-08-04 16:58 ` Konrad Dybcio
2023-08-07 4:41 ` Pavan Kondeti
2023-08-02 9:59 ` [PATCH 4/8] arm64: dts: qcom: Add PMIC pmx75 dtsi Rohit Agarwal
2023-08-02 12:46 ` Konrad Dybcio
2023-08-02 13:13 ` Rohit Agarwal
2023-08-02 9:59 ` [PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65 Rohit Agarwal
2023-08-02 12:46 ` Konrad Dybcio
2023-08-02 13:17 ` Rohit Agarwal
2023-08-02 9:59 ` [PATCH 6/8] arm64: dts: qcom: sdx75-idp: Add pmics supported in SDX75 Rohit Agarwal
2023-08-02 9:59 ` [PATCH 7/8] arm64: dts: qcom: sdx75: Add rpmhpd node Rohit Agarwal
2023-08-02 12:48 ` Konrad Dybcio
2023-08-02 13:17 ` Rohit Agarwal
2023-08-02 9:59 ` [PATCH 8/8] arm64: dts: qcom: sdx75-idp: Add regulator nodes Rohit Agarwal
2023-08-02 12:49 ` Konrad Dybcio [this message]
2023-08-02 17:57 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41b9bbd2-e58f-810d-ad3b-715423ffe74b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).