From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 1/4 v2] iio: exyno-adc: use syscon for PMU register access Date: Thu, 17 Jul 2014 15:56:55 +0200 Message-ID: <4202302.OdUuvHROuH@amdc1032> References: <1405595993-16661-1-git-send-email-ch.naveen@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7Bit Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Naveen Krishna Ch Cc: Sachin Kamat , Naveen Krishna Chatradhi , linux-iio@vger.kernel.org, linux-samsung-soc , "open list:OPEN FIRMWARE AND..." , open list , Chanwoo Choi , Greg Kroah-Hartman , Lars-Peter Clausen , cpgs@samsung.com, Grant Grundler , jic23@kernel.org List-Id: devicetree@vger.kernel.org Hi, On Thursday, July 17, 2014 05:41:16 PM Naveen Krishna Ch wrote: > Hello Sachin, > > On 17 July 2014 17:24, Sachin Kamat wrote: > > Hi Naveen, > > > > On Thu, Jul 17, 2014 at 4:49 PM, Naveen Krishna Chatradhi > > wrote: > >> This patch updates the IIO based ADC driver to use syscon and regmap > >> APIs to access and use PMU registers instead of remapping the PMU > >> registers in the driver. > >> > >> Signed-off-by: Naveen Krishna Chatradhi > >> To: linux-iio@vger.kernel.org > > > > With only this patch applied, I believe the ADC functionality would be broken. > > Perhaps the DT changes should be merged along with this patch? > > Jonathan already mentioned that, he would wait for Ack from Kukjin. > With out the dts changes ADC driver will fail to probe but it wont > crash the system. > git bisect should still work. Unless someone bisects things related to ADC functionality.. Also patch #1 seems to break device tree ABI (the old dtb will no longer work with the new kernel). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics