From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: smtp.subspace.kernel.org; dkim=none
Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130])
	by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4E6EEA
	for <devicetree@vger.kernel.org>; Mon, 27 Nov 2023 02:50:18 -0800 (PST)
Received: from i53875bf8.versanet.de ([83.135.91.248] helo=diego.localnet)
	by gloria.sntech.de with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <heiko@sntech.de>)
	id 1r7ZBv-0000i7-II; Mon, 27 Nov 2023 11:50:15 +0100
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Dragan Simic <dsimic@manjaro.org>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Tim Lunn <tim@feathertop.org>, Jagan Teki <jagan@edgeble.ai>,
 Rob Herring <robh+dt@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes
Date: Mon, 27 Nov 2023 11:50:14 +0100
Message-ID: <4234862.3Lj2Plt8kZ@diego>
In-Reply-To: <4bd0ce0f496646209eb8b220dfdd80bd@manjaro.org>
References:
 <20231122122232.952696-1-tim@feathertop.org> <4065853.CrzyxZ31qj@diego>
 <4bd0ce0f496646209eb8b220dfdd80bd@manjaro.org>
Precedence: bulk
X-Mailing-List: devicetree@vger.kernel.org
List-Id: <devicetree.vger.kernel.org>
List-Subscribe: <mailto:devicetree+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:devicetree+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Am Montag, 27. November 2023, 11:43:05 CET schrieb Dragan Simic:
> On 2023-11-27 11:29, Heiko St=FCbner wrote:
> > Am Montag, 27. November 2023, 10:58:43 CET schrieb Tim Lunn:
> >> On 11/27/23 20:45, Heiko St=FCbner wrote:
> >>> It's different for mmc, where this naming scheme isn't normally used,
> >>> so we (mostly?) migrated to them being in the board-specific alias=20
> >>> section.
> >>=20
> >> What about the ethernet alias, the MAC is part of the SoC, should this
> >> stay as it is in patch 6 from this series, or move to board dtsi?
> >=20
> > I think judging from everything above (and the other modern boards
> > like all rk3588 ones) the ethernet0 alias should move to the board=20
> > dts(i).
> >=20
> > The gmac generally does not have this numbering scheme like i2c or=20
> > uarts.
>=20
> Please note there's already an Ethernet alias defined in rk3399.dtsi,=20
> even despite not all RK3399-based devices using the GMAC, for example=20
> the Pinebook Pro.  Perhaps that's something to be fixed as well.

possibly :-)

I guess for starters we shouldn't introduce new instances for it.

All the newer SoCs already have their ethernet alias in the board dts
(rk356x, rk3568) which came after we also moved the mmc aliases.


Heiko