From: Arnd Bergmann <arnd@arndb.de>
To: Bart Tanghe <bart.tanghe@thomasmore.be>
Cc: thierry.reding@gmail.com, michal.simek@xilinx.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, grant.likely@linaro.org,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [rfc]pwm: add xilinx pwm driver
Date: Thu, 15 May 2014 09:23:59 +0200 [thread overview]
Message-ID: <4262573.aEBTd7FzV5@wuerfel> (raw)
In-Reply-To: <1400066773-14393-1-git-send-email-bart.tanghe@thomasmore.be>
On Wednesday 14 May 2014 13:26:13 Bart Tanghe wrote:
> @@ -0,0 +1,20 @@
> +Xilinx PWM controller
> +
> +Required properties:
> +- compatible: should be "xlnx,pwm-xlnx"
> +- add a clock source to the description
> +
> +Examples:
> +
> + axi_timer_0: timer@42800000 {
> + clock-frequency = <100000000>;
> + clocks = <&clkc 15>;
> + compatible = "xlnx,xlnx-pwm";
> + reg = <0x42800000 0x10000>;
> + xlnx,count-width = <0x20>;
> + xlnx,gen0-assert = <0x1>;
> + xlnx,gen1-assert = <0x1>;
> + xlnx,one-timer-only = <0x0>;
> + xlnx,trig0-assert = <0x1>;
> + xlnx,trig1-assert = <0x1>;
> + } ;
>
It seems you are missing a mandatory "#pwm-cells" property.
How is anybody supposed to use this?
Arnd
next prev parent reply other threads:[~2014-05-15 7:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 11:26 [rfc]pwm: add xilinx pwm driver Bart Tanghe
2014-05-15 7:23 ` Arnd Bergmann [this message]
2014-05-15 8:50 ` Bart Tanghe
2014-05-15 10:33 ` Michal Simek
2014-05-15 11:30 ` Bart Tanghe
2014-05-15 11:54 ` Michal Simek
2014-05-15 9:48 ` Michal Simek
[not found] ` <53748D84.5040005-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-05-15 12:20 ` Arnd Bergmann
2014-05-15 13:56 ` Michal Simek
2014-05-15 16:30 ` Arnd Bergmann
2014-05-15 20:49 ` Thierry Reding
2014-05-16 8:44 ` Michal Simek
2014-05-16 7:53 ` Michal Simek
2014-09-04 10:41 ` Bart Tanghe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4262573.aEBTd7FzV5@wuerfel \
--to=arnd@arndb.de \
--cc=bart.tanghe@thomasmore.be \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox