From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5FF8C433E0 for ; Fri, 5 Feb 2021 18:22:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82B0464FD1 for ; Fri, 5 Feb 2021 18:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232778AbhBEQkV (ORCPT ); Fri, 5 Feb 2021 11:40:21 -0500 Received: from sibelius.xs4all.nl ([83.163.83.176]:64066 "EHLO sibelius.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233223AbhBEQiT (ORCPT ); Fri, 5 Feb 2021 11:38:19 -0500 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 700eed23; Fri, 5 Feb 2021 15:19:53 +0100 (CET) Date: Fri, 5 Feb 2021 15:19:53 +0100 (CET) From: Mark Kettenis To: Johan Jonker CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/8] arm64: dts: rockchip: restyle rk3399 usbdrd3_0 node Message-ID: <4268f9759816bb98@bloch.sibelius.xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > For rk3399 dwc3 usb the wrapper node for only clocks makes no sense, > so restyle the rk3399 usbdrd3_0 node before more new SoC types are > added with the same IP. > > Signed-off-by: Johan Jonker > --- > Changed V3: > remove aclk_usb3_rksoc_axi_perf > remove aclk_usb3 > --- > arch/arm64/boot/dts/rockchip/rk3399-ficus.dts | 2 +- > arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 6 +--- > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 6 +--- > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 6 +--- > .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 6 +--- > arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts | 6 +--- > arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 4 --- > arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts | 6 +--- > .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 --- > .../arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 4 --- > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 4 --- > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 6 +--- > arch/arm64/boot/dts/rockchip/rk3399-rock960.dts | 2 +- > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 4 --- > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 6 +--- > arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 6 +--- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 37 ++++++++-------------- > .../boot/dts/rockchip/rk3399pro-vmarc-som.dtsi | 4 --- > 18 files changed, 24 insertions(+), 95 deletions(-) This change is problematic since: - compatible = "rockchip,rk3399-dwc3"; + compatible = "rockchip,rk3399-dwc3", "snps,dwc3"; This means that an existing "glue" driver will now attach to the node for the actual DWC3 controller. Not sure what the consequences exactly are on Linux, but on other systems that consume device trees (e.g. U-Boot, OpenBSD) this may break things because only the glue driver attaches. And even if on Linux both the "glue" driver and the "core" driver can share a single device tree node, this will still lead to multiple drivers manipulating the same clocks and resets, which I think is undesirable. You could introduce a new rk3399-specific compatible for the node. But I don't think this device tree binding change is helpful. Cheers, Mark