From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>,
jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: Add TI TWL603X GPADC
Date: Sat, 19 Aug 2023 20:35:27 +0200 [thread overview]
Message-ID: <426d78d6-9fa6-bfeb-b36a-fba264097a27@linaro.org> (raw)
In-Reply-To: <20230816202614.324457-1-andreas@kemnade.info>
On 16/08/2023 22:26, Andreas Kemnade wrote:
> Document TI TWL603X GPADC devicetree bindings.
> A driver is already there, the compatibles are used, but not documented.
> Use two separate files to reference only the allowed compatible in
> a future YAML version of
> Documentation/devicetree/bindings/mfd/twl-family.txt
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
Thank you for your patch. There is something to discuss/improve.
> .../bindings/iio/adc/ti,twl6030-gpadc.yaml | 42 +++++++++++++++++++
> .../bindings/iio/adc/ti,twl6032-gpadc.yaml | 42 +++++++++++++++++++
> 2 files changed, 84 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,twl6032-gpadc.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml
> new file mode 100644
> index 000000000000..08bc0468f616
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,twl6030-gpadc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPADC subsystem in the TWL6030 power module
> +
> +maintainers:
> + - Jonathan Cameron <jic23@kernel.org>
This should be rather someone knowing or having or caring about this
particular hardware, not subsystem maintainer.
> +
> +description:
> + The GPADC subsystem in the TWL6030 consists of a 10-bit ADC
> + combined with a 15-input analog multiplexer.
> +
> +properties:
> + compatible:
> + const: ti,twl6030-gpadc
Devices look fairly similar. Same properties. Why aren't they in one
binding (enum here instead)?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-20 0:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 20:26 [PATCH] dt-bindings: iio: adc: Add TI TWL603X GPADC Andreas Kemnade
2023-08-19 18:35 ` Krzysztof Kozlowski [this message]
2023-08-19 20:19 ` Andreas Kemnade
2023-08-20 6:29 ` Krzysztof Kozlowski
2023-09-05 6:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426d78d6-9fa6-bfeb-b36a-fba264097a27@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).