Re: [PATCH v1 3/3] dt-bindings: thermal: sun8i: Add binding for D1/T113s THS controller

Conor Dooley
2023-06-10T14:53:01Z

[-- Attachment #1: Type: text/plain, Size: 2693 bytes --]

On Sat, Jun 10, 2023 at 05:17:34PM +0300, Maksim Kiselev wrote:
> From: Maxim Kiselev <bigunclemax@gmail.com>
>
> Add a binding for D1/T113s thermal sensor controller.
>
> Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com>
> Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>

Why do you have 2 sign-offs that are both you w/ different spellings?
Content looks fine to me, other than one commit below.

> ---
> .../thermal/allwinner,sun8i-a83t-ths.yaml | 20 ++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> index fbd4212285e2..001faa37fc27 100644
> --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> @@ -16,6 +16,7 @@ properties:
> - allwinner,sun8i-a83t-ths
> - allwinner,sun8i-h3-ths
> - allwinner,sun8i-r40-ths
> + - allwinner,sun20i-d1-ths
> - allwinner,sun50i-a64-ths
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h5-ths
> @@ -61,6 +62,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - allwinner,sun20i-d1-ths
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h6-ths
>
> @@ -84,7 +86,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: allwinner,sun8i-h3-ths
> + enum:
> + - allwinner,sun8i-h3-ths
> + - allwinner,sun20i-d1-ths
>
> then:
> properties:
> @@ -103,6 +107,7 @@ allOf:
> enum:
> - allwinner,sun8i-h3-ths
> - allwinner,sun8i-r40-ths
> + - allwinner,sun20i-d1-ths
> - allwinner,sun50i-a64-ths
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h5-ths
> @@ -159,4 +164,17 @@ examples:
> #thermal-sensor-cells = <1>;
> };
>
> + - |
> + thermal-sensor@2009400 {
> + compatible = "allwinner,sun20i-d1-ths";
> + reg = <0x02009400 0x400>;
> + interrupts = <0 90 0>;
> + clocks = <&ccu 0>;
> + clock-names = "bus";
> + resets = <&ccu 2>;
> + nvmem-cells = <&ths_calibration>;
> + nvmem-cell-names = "calibration";
> + #thermal-sensor-cells = <0>;

Is this calibration required, or optional, for the d1?

Cheers,
Conor.

> + };
> +
> ...
> --
> 2.39.2
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]