Re: [PATCH v1 3/3] dt-bindings: thermal: sun8i: Add binding for D1/T113s THS controller

Conor Dooley
2023-06-10T18:01:41Z

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

On Sat, Jun 10, 2023 at 06:59:29PM +0100, Conor Dooley wrote:
> On Sat, Jun 10, 2023 at 06:30:48PM +0300, Maxim Kiselev wrote:
> > сб, 10 июн. 2023 г. в 17:52, Conor Dooley <conor@kernel.org>:
> >
> > ...
> >
> > >
> > > Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com>
> > > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>
> > >
> > >> Why do you have 2 sign-offs that are both you w/ different spellings?
> >
> > Sorry for that. I accidentally signed it twice.
> >
> > ...
> >
> > > + - |
> > > + thermal-sensor@2009400 {
> > > + compatible = "allwinner,sun20i-d1-ths";
> > > + reg = <0x02009400 0x400>;
> > > + interrupts = <0 90 0>;
> > > + clocks = <&ccu 0>;
> > > + clock-names = "bus";
> > > + resets = <&ccu 2>;
> > > + nvmem-cells = <&ths_calibration>;
> > > + nvmem-cell-names = "calibration";
> > > + #thermal-sensor-cells = <0>;
> > >
> > >> Is this calibration required, or optional, for the d1?
> >
> > Calibration data for the D1 is optional as for the H6.
> > (But without it, the sensor data will be inaccurate).
>
> Okay. Modulo the signoff:
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Wait, that's not what I meant to say... Clearly turned my brain off for
a moment. If it is not going to function correctly without the
calibration data, why not make the calibration data required for the
d1's ths?

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]