From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rajaganesh Rathinasabapathi <rrathina@amd.com>,
Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
joel@jms.id.au, andrew@codeconstruct.com.au, robh+dt@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Supreeth Venkatesh <supreeth.venkatesh@amd.com>
Subject: Re: [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
Date: Tue, 18 Mar 2025 17:58:50 +0100 [thread overview]
Message-ID: <4277e7d2-2449-4b82-8743-ba7f4581b02f@kernel.org> (raw)
In-Reply-To: <cfdbfe7e-5cf4-47a7-af5f-b220cad6f7e4@amd.com>
On 18/03/2025 17:44, Rajaganesh Rathinasabapathi wrote:
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It seems my or other reviewer's previous comments were not fully
>> addressed. Maybe the feedback got lost between the quotes, maybe you
>> just forgot to apply it. Please go back to the previous discussion and
>> either implement all requested changes or keep discussing them.
>>
>> Thank you.
>> </form letter>
>>
>> Best regards,
>> Krzysztof
>>
>
> There were two comments. One was to remove bootargs, this is addressed in v3.
> Another comment was to add compatibles for amd,onyx-bmc, it part of earlier commit (patch v3 1/2).
No, there were more.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-18 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 4:12 [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Rajaganesh Rathinasabapathi
2025-03-18 4:12 ` [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Rajaganesh Rathinasabapathi
2025-03-18 8:45 ` Krzysztof Kozlowski
2025-03-18 16:44 ` Rajaganesh Rathinasabapathi
2025-03-18 16:58 ` Krzysztof Kozlowski [this message]
2025-03-18 14:08 ` Andrew Lunn
2025-03-18 16:48 ` Rajaganesh Rathinasabapathi
2025-03-18 16:54 ` Andrew Lunn
2025-03-18 8:44 ` [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Krzysztof Kozlowski
2025-03-18 16:42 ` Rajaganesh Rathinasabapathi
2025-03-18 16:43 ` Krzysztof Kozlowski
2025-03-18 16:43 ` Krzysztof Kozlowski
2025-03-18 17:07 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4277e7d2-2449-4b82-8743-ba7f4581b02f@kernel.org \
--to=krzk@kernel.org \
--cc=Rajaganesh.Rathinasabapathi@amd.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=rrathina@amd.com \
--cc=supreeth.venkatesh@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox