public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible
@ 2025-03-18  4:12 Rajaganesh Rathinasabapathi
  2025-03-18  4:12 ` [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Rajaganesh Rathinasabapathi
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Rajaganesh Rathinasabapathi @ 2025-03-18  4:12 UTC (permalink / raw)
  To: devicetree, openbmc, joel, andrew
  Cc: robh+dt, krzk+dt, conor+dt, linux-arm-kernel, linux-aspeed,
	linux-kernel, Rajaganesh Rathinasabapathi

Document new AMD Onyx BMC board compatibles

Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 01333ac111fb..98f92c16e342 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -74,6 +74,7 @@ properties:
       - description: AST2600 based boards
         items:
           - enum:
+              - amd,onyx-bmc
               - ampere,mtjefferson-bmc
               - ampere,mtmitchell-bmc
               - aspeed,ast2600-evb
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
  2025-03-18  4:12 [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Rajaganesh Rathinasabapathi
@ 2025-03-18  4:12 ` Rajaganesh Rathinasabapathi
  2025-03-18  8:45   ` Krzysztof Kozlowski
  2025-03-18 14:08   ` Andrew Lunn
  2025-03-18  8:44 ` [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 13+ messages in thread
From: Rajaganesh Rathinasabapathi @ 2025-03-18  4:12 UTC (permalink / raw)
  To: devicetree, openbmc, joel, andrew
  Cc: robh+dt, krzk+dt, conor+dt, linux-arm-kernel, linux-aspeed,
	linux-kernel, Rajaganesh Rathinasabapathi, Supreeth Venkatesh

Add initial device tree and makefile updates for
AMD Onyx platform.

AMD Onyx platform is an AMD customer reference board with an Aspeed
ast2600 BMC manufactured by AMD.
It describes I2C devices, UARTs, MAC, FMC, etc.
present on AMD Onyx platform.

Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
---
Changes since v1:
* Incorporate review comments
* Update commit message
* Remove vmalloc and earlyprintk

Changes since v2:
* Address review comments
* Fix checkpatch warnings
* Remove bootargs
---
 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../boot/dts/aspeed/aspeed-bmc-amd-onyx.dts   | 102 ++++++++++++++++++
 2 files changed, 103 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts

diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile
index 2e5f4833a073..1e6a130377b8 100644
--- a/arch/arm/boot/dts/aspeed/Makefile
+++ b/arch/arm/boot/dts/aspeed/Makefile
@@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-ast2600-evb.dtb \
 	aspeed-bmc-amd-daytonax.dtb \
 	aspeed-bmc-amd-ethanolx.dtb \
+	aspeed-bmc-amd-onyx.dtb \
 	aspeed-bmc-ampere-mtjade.dtb \
 	aspeed-bmc-ampere-mtjefferson.dtb \
 	aspeed-bmc-ampere-mtmitchell.dtb \
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
new file mode 100644
index 000000000000..6f3334995398
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
@@ -0,0 +1,102 @@
+// SPDX-License-Identifier: GPL-2.0+
+// Copyright (c) 2021 - 2024 AMD Inc.
+// Author: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
+
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
+/ {
+	model = "AMD Onyx BMC";
+	compatible = "amd,onyx-bmc", "aspeed,ast2600";
+
+	aliases {
+		serial0 = &uart1;
+		serial4 = &uart5;
+	};
+
+	chosen {
+		stdout-path = serial4:115200n8;
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};
+
+};
+
+&mdio0 {
+	status = "okay";
+	ethphy0: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mac3 {
+	status = "okay";
+	phy-mode = "rgmii";
+	phy-handle = <&ethphy0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii4_default>;
+};
+
+&fmc {
+	status = "okay";
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		status = "okay";
+		#include "openbmc-flash-layout-128.dtsi"
+	};
+};
+
+//Host Console
+&uart1 {
+	status = "okay";
+};
+
+//BMC Console
+&uart5 {
+	status = "okay";
+};
+
+&gpio0 {
+gpio-line-names =
+	/*A0-A7*/	"","","","","","","","",
+	/*B0-B7*/	"","","","","MON_POST_COMPLETE","P0_PRESENT_L","","",
+	/*C0-C7*/	"","","","","","","","",
+	/*D0-D7*/	"","","","","","","","",
+	/*E0-E7*/	"","","","","","","","",
+	/*F0-F7*/	"","","","","","","","",
+	/*G0-G7*/	"","","","","","","","",
+	/*H0-H7*/	"","ASSERT_WARM_RST_BTN_L","ASSERT_SOC_RST_BTN_L","","","","","",
+	/*I0-I7*/	"","","","","","","","P0_I3C_APML_ALERT_L",
+	/*J0-J7*/	"","","","","","","","",
+	/*K0-K7*/	"","","","","","","","",
+	/*L0-L7*/	"","","","","","","","",
+	/*M0-M7*/	"","","","","","","","",
+	/*N0-N7*/	"","","","","","","PSP_SOFT_FUSE_NOTIFY","ASSERT_BMC_READY",
+	/*O0-O7*/	"","","HDT_SEL","HDT_XTRIG5","HDT_XTRIG6","JTAG_TRST_N","","",
+	/*P0-P7*/	"MON_RST_BTN_L","ASSERT_RST_BTN_L","MON_PWR_BTN_L","ASSERT_PWR_BTN_L",
+					"HPM_FPGA_LOCKOUT","ASSERT_NMI_BTN_L","MON_PWR_GOOD","",
+	/*Q0-Q7*/	"","","HDT_DBREQ_L","","BIOS_SPD_MUX_CTRL_RELEASED_L","","","",
+	/*R0-R7*/	"","","","","","","","",
+	/*S0-S7*/	"","","","","","","P0_DIMM_AF_ERROR","P0_DIMM_GL_ERROR",
+	/*T0-T7*/	"","","","","","","","",
+	/*U0-U7*/	"","","","","","","","",
+	/*V0-V7*/	"","","","","","","","",
+	/*W0-W7*/	"","","","","","","","",
+	/*X0-X7*/	"","","","","","","","",
+	/*Y0-Y7*/	"","","","","","","","",
+	/*Z0-Z7*/	"","","","","","","","";
+};
+
+&i2c7 {
+	status = "okay";
+	mbeeprom@50 {
+		compatible = "atmel,24c256";
+		reg = <0x50>;
+	};
+};
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible
  2025-03-18  4:12 [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Rajaganesh Rathinasabapathi
  2025-03-18  4:12 ` [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Rajaganesh Rathinasabapathi
@ 2025-03-18  8:44 ` Krzysztof Kozlowski
  2025-03-18 16:42   ` Rajaganesh Rathinasabapathi
  2025-03-18 16:43 ` Krzysztof Kozlowski
  2025-03-18 17:07 ` Rob Herring (Arm)
  3 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18  8:44 UTC (permalink / raw)
  To: Rajaganesh Rathinasabapathi
  Cc: devicetree, openbmc, joel, andrew, robh+dt, krzk+dt, conor+dt,
	linux-arm-kernel, linux-aspeed, linux-kernel

On Mon, Mar 17, 2025 at 11:12:23PM -0500, Rajaganesh Rathinasabapathi wrote:
> Document new AMD Onyx BMC board compatibles
> 
> Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
> ---

Where is the changelog? What happened with this patch between v1 and v3?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
  2025-03-18  4:12 ` [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Rajaganesh Rathinasabapathi
@ 2025-03-18  8:45   ` Krzysztof Kozlowski
  2025-03-18 16:44     ` Rajaganesh Rathinasabapathi
  2025-03-18 14:08   ` Andrew Lunn
  1 sibling, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18  8:45 UTC (permalink / raw)
  To: Rajaganesh Rathinasabapathi
  Cc: devicetree, openbmc, joel, andrew, robh+dt, krzk+dt, conor+dt,
	linux-arm-kernel, linux-aspeed, linux-kernel, Supreeth Venkatesh

On Mon, Mar 17, 2025 at 11:12:24PM -0500, Rajaganesh Rathinasabapathi wrote:
> +/ {
> +	model = "AMD Onyx BMC";
> +	compatible = "amd,onyx-bmc", "aspeed,ast2600";
> +
> +	aliases {
> +		serial0 = &uart1;
> +		serial4 = &uart5;
> +	};
> +
> +	chosen {
> +		stdout-path = serial4:115200n8;
> +	};
> +
> +	memory@80000000 {
> +		device_type = "memory";
> +		reg = <0x80000000 0x80000000>;
> +	};
> +
> +};

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
  2025-03-18  4:12 ` [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Rajaganesh Rathinasabapathi
  2025-03-18  8:45   ` Krzysztof Kozlowski
@ 2025-03-18 14:08   ` Andrew Lunn
  2025-03-18 16:48     ` Rajaganesh Rathinasabapathi
  1 sibling, 1 reply; 13+ messages in thread
From: Andrew Lunn @ 2025-03-18 14:08 UTC (permalink / raw)
  To: Rajaganesh Rathinasabapathi
  Cc: devicetree, openbmc, joel, andrew, robh+dt, krzk+dt, conor+dt,
	linux-arm-kernel, linux-aspeed, linux-kernel, Supreeth Venkatesh

> +&mac3 {
> +	status = "okay";
> +	phy-mode = "rgmii";

Does the PCB have extra long clock lines to insert the 2ns RGMII
delay? Or are you another victim of aspeeds broken MAC/SCU driver?

       Andrew

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible
  2025-03-18  8:44 ` [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Krzysztof Kozlowski
@ 2025-03-18 16:42   ` Rajaganesh Rathinasabapathi
  2025-03-18 16:43     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 13+ messages in thread
From: Rajaganesh Rathinasabapathi @ 2025-03-18 16:42 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rajaganesh Rathinasabapathi
  Cc: devicetree, openbmc, joel, andrew, robh+dt, krzk+dt, conor+dt,
	linux-arm-kernel, linux-aspeed, linux-kernel, jothayot

On 3/18/25 14:14, Krzysztof Kozlowski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Mon, Mar 17, 2025 at 11:12:23PM -0500, Rajaganesh Rathinasabapathi wrote:
>> Document new AMD Onyx BMC board compatibles
>>
>> Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
>> ---
> 
> Where is the changelog? What happened with this patch between v1 and v3?
> 
> Best regards,
> Krzysztof
> 
Earlier patches did not add dt-binding patch. Added compatibles now in v3.
It was a review comment on earlier dts submission.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible
  2025-03-18  4:12 [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Rajaganesh Rathinasabapathi
  2025-03-18  4:12 ` [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Rajaganesh Rathinasabapathi
  2025-03-18  8:44 ` [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Krzysztof Kozlowski
@ 2025-03-18 16:43 ` Krzysztof Kozlowski
  2025-03-18 17:07 ` Rob Herring (Arm)
  3 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18 16:43 UTC (permalink / raw)
  To: Rajaganesh Rathinasabapathi, devicetree, openbmc, joel, andrew
  Cc: robh+dt, krzk+dt, conor+dt, linux-arm-kernel, linux-aspeed,
	linux-kernel

On 18/03/2025 05:12, Rajaganesh Rathinasabapathi wrote:
> Document new AMD Onyx BMC board compatibles
> 
> Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
> ---
>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible
  2025-03-18 16:42   ` Rajaganesh Rathinasabapathi
@ 2025-03-18 16:43     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18 16:43 UTC (permalink / raw)
  To: Rajaganesh Rathinasabapathi, Rajaganesh Rathinasabapathi
  Cc: devicetree, openbmc, joel, andrew, robh+dt, krzk+dt, conor+dt,
	linux-arm-kernel, linux-aspeed, linux-kernel, jothayot

On 18/03/2025 17:42, Rajaganesh Rathinasabapathi wrote:
>>
>> Where is the changelog? What happened with this patch between v1 and v3?
>>
>> Best regards,
>> Krzysztof
>>
> Earlier patches did not add dt-binding patch. Added compatibles now in v3.
> It was a review comment on earlier dts submission.


Then your changelog says this is a new patch in the series.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
  2025-03-18  8:45   ` Krzysztof Kozlowski
@ 2025-03-18 16:44     ` Rajaganesh Rathinasabapathi
  2025-03-18 16:58       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 13+ messages in thread
From: Rajaganesh Rathinasabapathi @ 2025-03-18 16:44 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rajaganesh Rathinasabapathi
  Cc: devicetree, openbmc, joel, andrew, robh+dt, krzk+dt, conor+dt,
	linux-arm-kernel, linux-aspeed, linux-kernel, Supreeth Venkatesh

On 3/18/25 14:15, Krzysztof Kozlowski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Mon, Mar 17, 2025 at 11:12:24PM -0500, Rajaganesh Rathinasabapathi wrote:
>> +/ {
>> +     model = "AMD Onyx BMC";
>> +     compatible = "amd,onyx-bmc", "aspeed,ast2600";
>> +
>> +     aliases {
>> +             serial0 = &uart1;
>> +             serial4 = &uart5;
>> +     };
>> +
>> +     chosen {
>> +             stdout-path = serial4:115200n8;
>> +     };
>> +
>> +     memory@80000000 {
>> +             device_type = "memory";
>> +             reg = <0x80000000 0x80000000>;
>> +     };
>> +
>> +};
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> </form letter>
> 
> Best regards,
> Krzysztof
> 

There were two comments. One was to remove bootargs, this is addressed in v3.
Another comment was to add compatibles for amd,onyx-bmc, it part of earlier commit (patch v3 1/2).

Thanks,
Raja

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
  2025-03-18 14:08   ` Andrew Lunn
@ 2025-03-18 16:48     ` Rajaganesh Rathinasabapathi
  2025-03-18 16:54       ` Andrew Lunn
  0 siblings, 1 reply; 13+ messages in thread
From: Rajaganesh Rathinasabapathi @ 2025-03-18 16:48 UTC (permalink / raw)
  To: Andrew Lunn, Rajaganesh Rathinasabapathi
  Cc: devicetree, openbmc, joel, andrew, robh+dt, krzk+dt, conor+dt,
	linux-arm-kernel, linux-aspeed, linux-kernel, Supreeth Venkatesh,
	jothayot

On 3/18/25 19:38, Andrew Lunn wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
>> +&mac3 {
>> +     status = "okay";
>> +     phy-mode = "rgmii";
> 
> Does the PCB have extra long clock lines to insert the 2ns RGMII
> delay? Or are you another victim of aspeeds broken MAC/SCU driver?
> 
>        Andrew
We're following Aspeed SDK and referred other dts based on ast2600.
I assume Aspeed has moved clock delays to u-boot.
Link: https://lore.kernel.org/lkml/SG2PR06MB23150B3673E58737ABB08D51E6139@SG2PR06MB2315.apcprd06.prod.outlook.com/


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
  2025-03-18 16:48     ` Rajaganesh Rathinasabapathi
@ 2025-03-18 16:54       ` Andrew Lunn
  0 siblings, 0 replies; 13+ messages in thread
From: Andrew Lunn @ 2025-03-18 16:54 UTC (permalink / raw)
  To: Rajaganesh Rathinasabapathi
  Cc: Rajaganesh Rathinasabapathi, devicetree, openbmc, joel, andrew,
	robh+dt, krzk+dt, conor+dt, linux-arm-kernel, linux-aspeed,
	linux-kernel, Supreeth Venkatesh, jothayot

On Tue, Mar 18, 2025 at 10:18:46PM +0530, Rajaganesh Rathinasabapathi wrote:
> On 3/18/25 19:38, Andrew Lunn wrote:
> > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> > 
> > 
> >> +&mac3 {
> >> +     status = "okay";
> >> +     phy-mode = "rgmii";
> > 
> > Does the PCB have extra long clock lines to insert the 2ns RGMII
> > delay? Or are you another victim of aspeeds broken MAC/SCU driver?
> > 
> >        Andrew
> We're following Aspeed SDK and referred other dts based on ast2600.

Which are all broken.

At the moment, you are joining NVIDIA and IBM waiting for Aspeed to
sort out this mess. Maybe you can apply some pressure...

     Andrew

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
  2025-03-18 16:44     ` Rajaganesh Rathinasabapathi
@ 2025-03-18 16:58       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18 16:58 UTC (permalink / raw)
  To: Rajaganesh Rathinasabapathi, Rajaganesh Rathinasabapathi
  Cc: devicetree, openbmc, joel, andrew, robh+dt, krzk+dt, conor+dt,
	linux-arm-kernel, linux-aspeed, linux-kernel, Supreeth Venkatesh

On 18/03/2025 17:44, Rajaganesh Rathinasabapathi wrote:
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It seems my or other reviewer's previous comments were not fully
>> addressed. Maybe the feedback got lost between the quotes, maybe you
>> just forgot to apply it. Please go back to the previous discussion and
>> either implement all requested changes or keep discussing them.
>>
>> Thank you.
>> </form letter>
>>
>> Best regards,
>> Krzysztof
>>
> 
> There were two comments. One was to remove bootargs, this is addressed in v3.
> Another comment was to add compatibles for amd,onyx-bmc, it part of earlier commit (patch v3 1/2).
No, there were more.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible
  2025-03-18  4:12 [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Rajaganesh Rathinasabapathi
                   ` (2 preceding siblings ...)
  2025-03-18 16:43 ` Krzysztof Kozlowski
@ 2025-03-18 17:07 ` Rob Herring (Arm)
  3 siblings, 0 replies; 13+ messages in thread
From: Rob Herring (Arm) @ 2025-03-18 17:07 UTC (permalink / raw)
  To: Rajaganesh Rathinasabapathi
  Cc: linux-aspeed, andrew, linux-arm-kernel, krzk+dt, linux-kernel,
	openbmc, devicetree, joel, conor+dt, robh+dt


On Mon, 17 Mar 2025 23:12:23 -0500, Rajaganesh Rathinasabapathi wrote:
> Document new AMD Onyx BMC board compatibles
> 
> Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
> ---
>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for 20250318041224.1693323-1-Rajaganesh.Rathinasabapathi@amd.com:

Error: arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts:20.25-31 syntax error
FATAL ERROR: Unable to parse input tree
make[3]: *** [scripts/Makefile.dtbs:131: arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dtb] Error 1
make[2]: *** [scripts/Makefile.build:461: arch/arm/boot/dts/aspeed] Error 2
make[2]: Target 'arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dtb' not remade because of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1475: aspeed/aspeed-bmc-amd-onyx.dtb] Error 2
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-spc621d8hm3.dtb: /ahb/apb@1e780000/pwm-tacho-controller@1e786000: failed to match any schema with compatible: ['aspeed,ast2500-pwm-tacho']
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'aspeed/aspeed-bmc-microsoft-olympus.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-delta-ahe50dc.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-palmetto.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-ast2500-evb.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-quanta-s6q.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-romulus.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-sbp1.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-inspur-fp5280g2.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-minipack.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-mowgli.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-witherspoon.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-vegman-sx20.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-tacoma.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-lanyang.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-vegman-rx20.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-fuji.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-everest.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-bytedance-g220a.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-cmm.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-blueridge-4u.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-asrock-e3c246d4i.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-ast2600-evb-a1.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-amd-onyx.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-supermicro-x11spi.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-vegman-n110.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-vesnin.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-bletchley.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-ast2600-evb.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-inventec-transformers.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-rainier.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-tyan-s8036.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ampere-mtjade.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-asrock-x570d4u.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-yosemite4.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-blueridge.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-asrock-spc621d8hm3.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-inventec-starscream.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-rainier-1s4u.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-yamp.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-rainier-4u.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-catalina.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-amd-ethanolx.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-bonnell.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-inspur-on5263m5.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ampere-mtjefferson.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-asus-x4tf.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-nicole.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-intel-s2600wf.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-wedge40.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-lenovo-hr855xg2.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-asrock-e3c256d4i.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-lenovo-hr630.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-asrock-romed8hm3.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-quanta-q71l.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-tyan-s7106.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-yosemitev2.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-wedge100.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-elbert.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-amd-daytonax.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-qcom-dc-scm-v1.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ufispace-ncplite.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-opp-zaius.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-portwell-neptune.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ampere-mtmitchell.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-fuji.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-minerva.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-galaxy100.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-harma.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-inspur-nf5280m6.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-wedge400.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-arm-stardragon4800-rep2.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-ibm-system1.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-greatlakes.dtb' not remade because of errors.
make: Target 'aspeed/aspeed-bmc-facebook-tiogapass.dtb' not remade because of errors.






^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2025-03-18 17:07 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-18  4:12 [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Rajaganesh Rathinasabapathi
2025-03-18  4:12 ` [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Rajaganesh Rathinasabapathi
2025-03-18  8:45   ` Krzysztof Kozlowski
2025-03-18 16:44     ` Rajaganesh Rathinasabapathi
2025-03-18 16:58       ` Krzysztof Kozlowski
2025-03-18 14:08   ` Andrew Lunn
2025-03-18 16:48     ` Rajaganesh Rathinasabapathi
2025-03-18 16:54       ` Andrew Lunn
2025-03-18  8:44 ` [PATCH v3 1/2] dt-bindings: arm: aspeed: Add AMD Onyx BMC compatible Krzysztof Kozlowski
2025-03-18 16:42   ` Rajaganesh Rathinasabapathi
2025-03-18 16:43     ` Krzysztof Kozlowski
2025-03-18 16:43 ` Krzysztof Kozlowski
2025-03-18 17:07 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox