Re: [PATCH 8/9] drm/panthor: Add i.MX95 support

Marek Vasut
2025-02-28T18:27:22Z

On 2/28/25 11:21 AM, Alexander Stein wrote:

Hi,

>> diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c
>> index 0f07ef7d9aea7..2371ab8e50627 100644
>> --- a/drivers/gpu/drm/panthor/panthor_gpu.c
>> +++ b/drivers/gpu/drm/panthor/panthor_gpu.c
>> @@ -67,6 +67,7 @@ struct panthor_model {
>> }
>>
>> static const struct panthor_model gpu_models[] = {
>> + GPU_MODEL(g310, 0, 0), /* NXP i.MX95 */
>
> Are you sure about 0, 0?

I am not.

> With this I get
>> [drm] mali-unknown id 0xac74 major 0x0 minor 0x0 status 0x1
>
> Using GPU_MODEL(g310, 10, 4) I get:
>> [drm] mali-g310 id 0xac74 major 0x0 minor 0x0 status 0x1
>
> Note the output is GPU_VER_MAJOR() but this table is for GPU_ARCH_MAJOR()
> (and the corresponding minor).
The major 0x0 minor 0x0 is where I took the 0,0 from. Lemme update this.