From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C357AFC6195 for ; Fri, 8 Nov 2019 14:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 948DA214DB for ; Fri, 8 Nov 2019 14:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726812AbfKHOe2 (ORCPT ); Fri, 8 Nov 2019 09:34:28 -0500 Received: from gloria.sntech.de ([185.11.138.130]:59408 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfKHOe2 (ORCPT ); Fri, 8 Nov 2019 09:34:28 -0500 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iT5Kx-0001br-PV; Fri, 08 Nov 2019 15:34:07 +0100 From: Heiko Stuebner To: Andrew Murray Cc: Tsahee Zidenberg , Antoine Tenart , Rob Herring , Mark Rutland , Brijesh Singh , Suravee Suthikulpanit , Tom Lendacky , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Robert Richter , Jayachandran C , Shawn Guo , Li Yang , Wei Xu , Andy Gross , Masahiro Yamada , Michal Simek , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v1 2/7] arm64: dts: Use IRQ flags for legacy PCI IRQ interrupts Date: Fri, 08 Nov 2019 15:34:06 +0100 Message-ID: <4293211.PqsBVBjssI@phil> In-Reply-To: <20191104163834.8932-3-andrew.murray@arm.com> References: <20191104163834.8932-1-andrew.murray@arm.com> <20191104163834.8932-3-andrew.murray@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Montag, 4. November 2019, 17:38:16 CET schrieb Andrew Murray: > Replace magic numbers used to describe legacy PCI IRQ interrupts > with #define. > > Signed-off-by: Andrew Murray > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index cede1ad81be2..bb68826bac6f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -242,11 +242,11 @@ > , > ; > interrupt-names = "sys", "legacy", "client"; > - interrupt-map-mask = <0 0 0 7>; > - interrupt-map = <0 0 0 1 &pcie0_intc 0>, > - <0 0 0 2 &pcie0_intc 1>, > - <0 0 0 3 &pcie0_intc 2>, > - <0 0 0 4 &pcie0_intc 3>; > + interrupt-map-mask = <0 0 0 IRQ_INT_ALL>; > + interrupt-map = <0 0 0 IRQ_INTA &pcie0_intc 0>, > + <0 0 0 IRQ_INTB &pcie0_intc 1>, > + <0 0 0 IRQ_INTC &pcie0_intc 2>, > + <0 0 0 IRQ_INTD &pcie0_intc 3>; > linux,pci-domain = <0>; > max-link-speed = <1>; > msi-map = <0x0 &its 0x0 0x1000>; For the Rockchip part Acked-by: Heiko Stuebner