From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20A9A3AA4E1 for ; Thu, 14 May 2026 06:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778739769; cv=none; b=MLQUTziu9N1J8iVaR0tlBLAjoUjufoWgWL3lip/0I7qFr26nzPZKBoUgPfXBe2vRPDEUM/gZeMc42anmh1tKp8QF28aWTrbS/rRspa8BXAPCKqgUt7xJojs8KDxXAG8yM2ZgmLSxPAN45j1ni4R5dEr1tT2cMpgg+PZzDYVDQlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778739769; c=relaxed/simple; bh=r5CNeoyi9PFS7Rp+BVPOhykJh4AQPo3yRx3ClIiQIxQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mM3Y4FVUaRC46Obh0MaSTK8yu5u2TgH3ZZfSvfRUQK9JZrWuBkaoOsca1c+akNo/NG2rzAv6xjk0dgR+j1C0maS9ulwv6Tg40VQJBahIIyYWm3z4JezVgTPialNXxkk9n4MWQTIKzrIDNqVFAU+WG00vjifEgdiUAffYc22eOEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aNs9xl3B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AQKtzWbr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aNs9xl3B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AQKtzWbr" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64E4gcst3013737 for ; Thu, 14 May 2026 06:22:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W6EuO2zZJQMU48rIvtrMMeNXywoABvRlbsWA7IZNce0=; b=aNs9xl3BBfVZl8pk qh/mM2TZ+l3EE6a8/fdXpllfxtanJ9H3VVCRl4udunvnOf9QRj7jCje/MErO/MIX EB2Heg5Pdt1zBZpILOB50iPJPfQXaPFgp7FZpm5yU6+3Ed4AuAp+nwI28rg1AHBH kcuAapxSZuOsU+Y06UeHppMOb2VczDvxFZ+Y8JTMWy1b32g52LTWxUiUYYcuYA12 lkUMsEmpH5+oZIVLl9QTkvI1D4ANqiR+f5rmusexKE+PWwrI98fV2Su4q0Cwazfv HUfdOj6LQ1odnHxu8XzlatQQNb2NHZdVbKcPQjneG5d5cgqNJonxH7tAJn1GKV5K UHZ9MQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e57ksr94s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 06:22:47 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c802545ae0eso4498933a12.2 for ; Wed, 13 May 2026 23:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778739767; x=1779344567; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W6EuO2zZJQMU48rIvtrMMeNXywoABvRlbsWA7IZNce0=; b=AQKtzWbr+4gcO9Rb+V573nq38HcA0I7VeEAtpCuu+FeMtUW7TEnvn/yicnQcP5l1lV EiVelVdB8KGORhfAxEeSdQjJCBgS6G4vWvDMYbKn48fSI2eACEa0wspxatCD3izRvg4P MkCaFV6igZe1ihm3q3wLjX3AWwnkHOibC+gFIyO4w9kgAU7lyiY/t4wXC3D1tzOjNt83 86pCavwmiQrTEY7s7OGDKOqTBW1XzqMg3W2IyXr5H0hUC9RfRSvoz0bipBwdIu2QdMJU 87ld+kvGUAnBAAQoXCsen2l17WBOA8nv0QhxIpWQUvVu3/ejxIlSN3GEK+9BxqhF0kWr /iBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778739767; x=1779344567; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W6EuO2zZJQMU48rIvtrMMeNXywoABvRlbsWA7IZNce0=; b=S2ozj8hweag1FdgV5/m9DgBVBFELzdLyEZlOn4fPTls7rA2BZP2eyH55mEEAz3Hqp3 opvbYv+MIXt7Bt4nEMF/+Sf9CxE9Q7teESjvGeLFMMsUHGGAQRoKAmglYI2d/gjsB7du 9u8hv0bhFkmtAwbV2l+bZMBCkqZACRHH679Ukddx/NJSdlf25dwtAIlyLpoasdb0+KaR VWoDNPjjuEEj276XtSfmr7AG1D8/BjiBqYLO8VWSXnl/eI+EGYhCTWBAMpeltu42WRtK g9sozCWtLUrMs6ngVI5EgHQfFnEpiu1z+WG8IlXH5I2onYEnpqglL+x61uC7+v3m2bjn ULSw== X-Forwarded-Encrypted: i=1; AFNElJ9P8RuRHhm0Bd2HqeikUcnnNsn4esuBTOCeKgpIqSUIz9ojWvzuh+/5lvUzWm9EkZ/CvSViAvhra9hR@vger.kernel.org X-Gm-Message-State: AOJu0YwRjSoGzTZxhGodM2rHWR1Uq/men8SGxryRek59YuG3PRj3gnQD XhWsoBehRc49zJqW8D0btbZcDoP/aJrcCVa9puaPxlzf9v6U3K56UN/zncnjTV4CRzAQAhB35TI oApxkIi6P5NnbMFCxb/6sNazJsi0W5igF1FDutVukACJyGAaozM3iNmZWqwM/flS+ X-Gm-Gg: Acq92OHu+8Z9Ee1KpRizlHppDgX9dmPqmRkMvW76kidPBzy8aaVkouSe0TjtdXERsfI Swj3XLOiF5xib+Sp/rFbtLYHc9zjvSTPjKT8Km+UtnZklYNQYFXJ+A76O3mGgWNUK1VkLcls8GS Y+4F/EWa8XPZDQh4WtZ5Eh+BBEnxotxfAGgIBSY5S3cCcTl7Mt+JtpY6A2BpOSX4aBDzEHAv/VF tVSy1fCwEcUf/0hUZRnoT0XUR/vKf2cgr6hMlVbnSzwuPgoXgJmIVodihMkJAJtkoDsvaRKgY2H /cqDE1Mx8/yg7tEojcr9tH0oNusTwb5nVHZ8u5jX8p0NMpZ6IkM4ldjz7/bj30OlSL7EzQPuO5X Wfr7kj8Qu2Hh7TjX9iYnZyPG+tHYKRhlqwWYVpme3TbkfaxLRYPD7PV03xkQW2lOVphpWWVqLqc y8e4km+VMKjMcnOA== X-Received: by 2002:a05:6a00:339a:b0:834:efcb:12b4 with SMTP id d2e1a72fcca58-83f0428732amr6709141b3a.28.1778739766580; Wed, 13 May 2026 23:22:46 -0700 (PDT) X-Received: by 2002:a05:6a00:339a:b0:834:efcb:12b4 with SMTP id d2e1a72fcca58-83f0428732amr6709106b3a.28.1778739765951; Wed, 13 May 2026 23:22:45 -0700 (PDT) Received: from [10.217.219.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19663cfdsm1803149b3a.9.2026.05.13.23.22.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 23:22:45 -0700 (PDT) Message-ID: <42ba6ac7-306a-419f-96b6-3427c51ef567@oss.qualcomm.com> Date: Thu, 14 May 2026 11:52:39 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra To: Krzysztof Kozlowski Cc: Neil Armstrong , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Xiangxu Yin , Johan Hovold , Loic Poulain , Kathiravan Thirumoorthy , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260504170659.282532-1-krishna.kurapati@oss.qualcomm.com> <20260504170659.282532-3-krishna.kurapati@oss.qualcomm.com> <20260505-gifted-salamander-of-prowess-5107a6@quoll> <8cd564af-9646-40c5-a8ef-c7197fb3cfe9@kernel.org> <95b567cc-b83c-4154-9520-e624555f1882@oss.qualcomm.com> <29571bdd-23bf-42a7-a9e3-918a28c79700@kernel.org> <62161822-2365-4ec7-80f7-8660bdadb177@oss.qualcomm.com> <40b5e0f6-bc61-4750-9560-bdcc268f0fe3@kernel.org> <5baeeeed-7c18-46f7-82a3-5bb299ba05ef@kernel.org> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <5baeeeed-7c18-46f7-82a3-5bb299ba05ef@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: mUi1e9q-qtFDOJgQNXwdWCEuvdnY3SuB X-Authority-Analysis: v=2.4 cv=KZbidwYD c=1 sm=1 tr=0 ts=6a056a37 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=bDX-BmwN5UdOEqwmdTwA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDA2MSBTYWx0ZWRfX4M8AosnKNtuQ BVhvj9UlSvEZJQ/j+Bxsom3JvkqgU5or7HqCzu9XAZooqMIp8BzlQE0nf8a1j95iMXfeK7LBS7E 43OzyjMyP6WBBHIv9YSfS+9SlrUX31V7imRzToImEdE1FHec9kyWXzqNjShLGiDv4SSqz+kYG8S yrrOnl/qwxm2HLOlkifloc9kGw1wi2NtuCP8LU3/frGFQXGkbx1RcBLzTfPLZTvXEHcYYHUj+ou Rfnr2mOf8wWzzPtg5xc5eskcNWiJoNR4trl8RDlhy/1bU2GlVTzHPzHGw3C9VhcHrSUgwTMyaOX iPJvWKqPu+uN37F9LO426B8N+h3ipeEF2YC/dWbNtWbvHqzyNUc9s5IVc7DBHXtiKt2sUgHT4Mc 60TCtn/qO8S/HN66pRcMgq8ud+H7zO4wfxHvxCHY5nH9RdqLphTQk5DnB/+ltRg98T2di2nRRDe /WUUiUPjdADgiWtmk8g== X-Proofpoint-ORIG-GUID: mUi1e9q-qtFDOJgQNXwdWCEuvdnY3SuB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_01,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140061 On 5/14/2026 12:26 AM, Krzysztof Kozlowski wrote: > On 07/05/2026 13:37, Krishna Kurapati wrote: >> >> >> On 5/5/2026 7:30 PM, Krzysztof Kozlowski wrote: >>> On 05/05/2026 15:57, Krishna Kurapati wrote: >>>> >>>> >>>> On 5/5/2026 6:59 PM, Krzysztof Kozlowski wrote: >>>>> On 05/05/2026 15:27, Krishna Kurapati wrote: >>>>>> >>>>>> >>>>>> On 5/5/2026 4:22 PM, Krzysztof Kozlowski wrote: >>>>>>> On 05/05/2026 12:49, Krzysztof Kozlowski wrote: >>>>>>>> On Mon, May 04, 2026 at 10:36:57PM +0530, Krishna Kurapati wrote: >>>>>>>>> Declare the USB-C QMP PHY present on the Qualcomm Shikra platform. >>>>>>>>> >>>>>>>>> Signed-off-by: Krishna Kurapati >>>>>>>>> --- >>>>>>>>> .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 2 ++ >>>>>>>>> 1 file changed, 2 insertions(+) >>>>>>>> >>>>>>>> Reviewed-by: Krzysztof Kozlowski >>>>>>> >>>>>>> ... and then I looked at the driver. So un-reviewed. Devices are clearly >>>>>>> compatible. If not, explain what is not compatible. >>>>>>> >>>>>> Talos uses GCC_USB3_PRIM_PHY_AUX_CLK. >>>>>> >>>>>> In Shikra, we are using GCC_USB3_PRIM_PHY_COM_AUX_CLK. We don't have >>>>>> GCC_USB3_PRIM_PHY_AUX_CLK. >>>>>> >>>>>> Hence, I didn't use a fallback compatible. >>>>> >>>>> This still explains nothing. How different clock makes interface for SW >>>>> incompatible exactly? >>>>> >>>> So I went by the naming. AUX vs COM_AUX. >>> >>> The naming does not matter. If the clock is called >>> "no_one_expects_spanish_inquisition", does that make software >>> incompatible? Why would the name itself matter? >>> >>>> >>>> Can I use a fallback compatible and in DT vote for "COM_AUX" clock with >>>> clock-names mentioning "aux" ? >>> >>> I don't know, I asked what is different in software interface. >>> >> >> Hi Krzysztof, >> >> I checked with the hw team here and found out two things. >> >> 1. Shikra is a spinoff of Agatti and its sw interface (clocks used and >> regulators used) is the same as agatti. >> >> 2. I thought we could use qcm2290 as a fallback since the phy register >> init sequence is the same for Talos/Shikra/Agatti. The difference >> between Talos and agatti when checked in the driver was the init load >> settings. I checked with the hw team and they suggested using the init >> load settings which talos was using. >> >> Hence both these compatibles (qcm2290 and qcs615) cannot be used as >> fallback for Shikra. > > Then I do not understand why you are using qcs615_usb3phy_cfg for > Shikra. You say that the initialization is different, but you use > exactly the same initialization. So in a meaning of compatibility > between hardware for Devicetree they are compatible. > Hi Krzysztof, There are 3 things: 1. Clocks used: -> Talos supports AUX Clock since it supports DP over USB. -> Agatti and Shikra use COM_AUX clock since they dont support DP over USB. 2. Phy register Init sequence - same for all 3 targets 3. Regulator init load: -> Different for both Talos and Agatti -> Recommendation is to use Talos regulator load values. SW interface wise, shikra is comaptible with agatti. If we use agatti as fallback, we would end up using the platform data of Agatti where the regulator init load is not suitable for Shikra. Hence not using Agatti as fallback. Coming to driver changes, I used qcs615_cfg because it has required phy register sequence and regulator init load as needed by shikra. Regards, Krishna,