Re: [PATCH v4 5/5] leds: lt3593: update email address and switch to SPDX license header

[Jacek Anaszewski <jacek.anaszewski@gmail.com>]

Hi Daniel,

Thanks for sorting the things out.

Patch set applied to the for-next branch of linux-leds.git

I have one more remark while we are at it, please refer below.

On 06/21/2018 10:23 PM, Daniel Mack wrote:
> Update the email address in the module information and in the comments
> and in the module information, and drop the existing boilerplate in
> favor of a SPDX header.
> 
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> ---
>   drivers/leds/leds-lt3593.c | 21 +++------------------
>   1 file changed, 3 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c
> index b9a907e9d321..f6aae616242e 100644
> --- a/drivers/leds/leds-lt3593.c
> +++ b/drivers/leds/leds-lt3593.c
> @@ -1,20 +1,5 @@
> -/*
> - * LEDs driver for LT3593 controllers
> - *
> - * See the datasheet at http://cds.linear.com/docs/Datasheet/3593f.pdf
> - *
> - * Copyright (c) 2009 Daniel Mack <daniel@caiaq.de>
> - *
> - * Based on leds-gpio.c,
> - *
> - *   Copyright (C) 2007 8D Technologies inc.
> - *   Raphael Assenat <raph@8d.com>
> - *   Copyright (C) 2008 Freescale Semiconductor, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2009,2018 Daniel Mack <daniel@zonque.org>
>   
>   #include <linux/kernel.h>
>   #include <linux/platform_device.h>
> @@ -215,7 +200,7 @@ static struct platform_driver lt3593_led_driver = {
>   
>   module_platform_driver(lt3593_led_driver);
>   
> -MODULE_AUTHOR("Daniel Mack <daniel@caiaq.de>");
> +MODULE_AUTHOR("Daniel Mack <daniel@zonque.org>");
>   MODULE_DESCRIPTION("LED driver for LT3593 controllers");
>   MODULE_LICENSE("GPL");

I've just noticed the pre-existing discrepancy between the license
message (GPL v2) and MODULE_LICENSE("GPL"). Is there a reason to keep
it that way?

>   MODULE_ALIAS("platform:leds-lt3593");
> 

-- 
Best regards,
Jacek Anaszewski