From: Roger Quadros <rogerq@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: vigneshr@ti.com, kristo@kernel.org, srk@ti.com,
r-gunasekaran@ti.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Dhruva Gole <d-gole@ti.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am625-sk: Add ti,vbus-divider property to usbss1
Date: Sat, 25 Mar 2023 15:03:06 +0200 [thread overview]
Message-ID: <42bbac46-782b-e2ac-67f3-37489e3a2047@kernel.org> (raw)
In-Reply-To: <20230324181435.i2n2q6cvh6x4kabw@repeal>
On 24/03/2023 20:14, Nishanth Menon wrote:
> On 15:31-20230324, Roger Quadros wrote:
>> From: Dhruva Gole <d-gole@ti.com>
>>
>> The property "ti,vbus-divider" is needed for both usbss0 and usbss1 as
>> both USB0 and USB1 have the same external voltage divider circuit.
>>
>> Signed-off-by: Dhruva Gole <d-gole@ti.com>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> index 67dc26fc23e4..be027fad5f61 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> @@ -482,6 +482,7 @@ &usbss0 {
>>
>> &usbss1 {
>> status = "okay";
>> + ti,vbus-divider;
>> };
>>
>
> 1. Does'nt this need a fixes tag?
> 2. lakml is missing in CC
Will fix both issues.
>
>> &usb0 {
>> --
>> 2.34.1
>>
>
cheers,
-roger
next prev parent reply other threads:[~2023-03-25 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:31 [PATCH 0/2] arm64: dts: ti: k3-am625-sk: Enable Type-C dual-role Roger Quadros
2023-03-24 13:31 ` [PATCH 1/2] arm64: dts: ti: k3-am625-sk: Add ti,vbus-divider property to usbss1 Roger Quadros
2023-03-24 18:14 ` Nishanth Menon
2023-03-25 13:03 ` Roger Quadros [this message]
2023-03-24 13:31 ` [PATCH 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port for USB0 Roger Quadros
2023-03-24 18:15 ` Nishanth Menon
2023-03-25 13:03 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42bbac46-782b-e2ac-67f3-37489e3a2047@kernel.org \
--to=rogerq@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=r-gunasekaran@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).