From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D30C7619A for ; Thu, 6 Apr 2023 02:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233128AbjDFCU5 (ORCPT ); Wed, 5 Apr 2023 22:20:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbjDFCU5 (ORCPT ); Wed, 5 Apr 2023 22:20:57 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5784B6E88; Wed, 5 Apr 2023 19:20:55 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id C69C124E25E; Thu, 6 Apr 2023 10:20:53 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 6 Apr 2023 10:20:53 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 6 Apr 2023 10:20:53 +0800 Message-ID: <42bdb4e2-bb18-5e4d-f6fb-68564c89efee@starfivetech.com> Date: Thu, 6 Apr 2023 10:20:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RESEND v6 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc To: Conor Dooley CC: Krzysztof Kozlowski , , , , Rob Herring , "Krzysztof Kozlowski" , Emil Renner Berthing References: <20230315055813.94740-1-william.qiu@starfivetech.com> <20230315055813.94740-2-william.qiu@starfivetech.com> <850bc37e-c6d1-2381-a851-965a4cbee8a0@linaro.org> <20230405-bullseye-handsaw-5c2e4dab772f@spud> Content-Language: en-US From: William Qiu In-Reply-To: <20230405-bullseye-handsaw-5c2e4dab772f@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/6 0:38, Conor Dooley wrote: > On Mon, Mar 20, 2023 at 03:32:14PM +0800, William Qiu wrote: > >> >>> Does not look like you tested the bindings. Please run `make >> >>> dt_binding_check` (see >> >>> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> >>> >> >>> ... or your PLL clock controller was not tested. >> >>> >> >>> Best regards, >> >>> Krzysztof >> >>> >> >> Hi Krzysztof, >> >> >> >> I've already done`make dt_binding_check`, and get no error. So maybe PLL clock controller >> >> was not tested which I didn't add in this patch series. And PLL clock controller belongs >> >> to Xingyu Wu, I would tell him. >> > >> > What's confusing you do not allow here clock controller. > >> I'll add it then. > > What's the plan here William? > Can you sort something out with Xingyu Wu so that the dt-binding is > added in a complete manner? > In the meantime, gonna drop this series as "Changes Requested" from > patchwork. > > Cheers, > Conor. Hi Conor, After discussing with Xingyu, I will sort all of it and send a complete dt-binding today. Best regards, William