From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221 Date: Fri, 3 Jun 2016 13:04:53 +0100 Message-ID: <42c00dfb-bb45-405c-a1d2-516ece137826@kernel.org> References: <1464784454-7988-1-git-send-email-ldewangan@nvidia.com> <1464784454-7988-2-git-send-email-ldewangan@nvidia.com> <44e28639-67b6-7586-5e6d-c0180ccded79@kernel.org> <20f70b31-afb5-e012-0baf-ba0b83ac6d36@kernel.org> <57516A74.4060008@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <57516A74.4060008-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jean Delvare , Guenter Roeck List-Id: devicetree@vger.kernel.org On 03/06/16 12:31, Laxman Dewangan wrote: > > On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote: >> On 03/06/16 11:06, Jonathan Cameron wrote: >>> >>> Code looks good, bu these more fundamental bits need sorting. >> Another minor point - why do the power calculations in driver? >> no hardware support for it, so why not just leave it to userspace? > > Device supports the bus and shunt voltage monitoring. So even no current. Also the warning/critical limit is for the voltage across shunt. > > So should we only expose the shunt/bus voltage, no power/current? > > I am thinking that user space should not know the platform and hence shunt resistance and so exposing the current and power on bus is better option. > I'd go for current and voltage rather than current and power, but otherwise agree. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html