From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE053C433EF for ; Wed, 6 Apr 2022 13:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233362AbiDFNo0 (ORCPT ); Wed, 6 Apr 2022 09:44:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233988AbiDFNml (ORCPT ); Wed, 6 Apr 2022 09:42:41 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C83A2E930D; Wed, 6 Apr 2022 03:50:11 -0700 (PDT) X-UUID: d710005dabbd42d68bdd942d31903cc9-20220406 X-UUID: d710005dabbd42d68bdd942d31903cc9-20220406 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1297674620; Wed, 06 Apr 2022 18:50:01 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Wed, 6 Apr 2022 18:49:59 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 6 Apr 2022 18:49:59 +0800 Message-ID: <42e890bef5927f2c4854c146f9bab2f974b64a48.camel@mediatek.com> Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183 From: Rex-BC Chen To: AngeloGioacchino Del Regno , , , CC: , , , , , , , , , , , , Date: Wed, 6 Apr 2022 18:49:59 +0800 In-Reply-To: <19a1af29-19a7-a546-b565-a2cc973a7f28@collabora.com> References: <20220406094654.29722-1-rex-bc.chen@mediatek.com> <20220406094654.29722-2-rex-bc.chen@mediatek.com> <19a1af29-19a7-a546-b565-a2cc973a7f28@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 2022-04-06 at 12:38 +0200, AngeloGioacchino Del Regno wrote: > Il 06/04/22 11:46, Rex-BC Chen ha scritto: > > The driver data of MT8183 and MT8173 are different. > > The value of has_gamma for MT8173 is true while the value of MT8183 > > is > > false. Therefore, the compatible of disp_aal for MT8183 is not > > suitable > > for the compatible for MT8173. > > > > Signed-off-by: Rex-BC Chen > > Hello! > Yes, I definitely agree with this change, it makes no sense to have > both > 8173 and 8183 compatibles for 8183 (and similar). > > Though, please, add a note in this commit message advertising that > the > mistake was only in the yaml binding, as the driver doesn't require > any > functional changes, so that things are clear for people with less > expertise > on MediaTek platforms. > > After that: > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Hello Angelo, Thanks for your review. I will add them to the commit message in next version. BRs, Rex