From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CAD2CCCA for ; Fri, 5 Jan 2024 12:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i53875a56.versanet.de ([83.135.90.86] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rLizA-0003eS-Qv; Fri, 05 Jan 2024 13:07:36 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Jagan Teki Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Add Radxa ROCK 4C+ DSI DT-overlay Date: Fri, 05 Jan 2024 13:07:35 +0100 Message-ID: <4304443.fW5hKsROvD@diego> In-Reply-To: References: <20230731200559.635629-1-jagan@edgeble.ai> <2194166.1BCLMh4Saa@diego> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Hi Jagan, Am Montag, 13. November 2023, 16:15:34 CET schrieb Jagan Teki: > On Thu, 5 Oct 2023 at 06:07, Heiko St=FCbner wrote: > > > > Am Montag, 31. Juli 2023, 22:05:57 CEST schrieb Jagan Teki: > > > Add DSI pipeline for Radxa ROCK 4C+ board via DT-overlay. > > > > > > The DSI connector in Radxa ROCK 4C+ board support different > > > resolution panels and those compatible is added in another > > > DT-overlay. > > > > > > Signed-off-by: Jagan Teki > > > --- > > > arch/arm64/boot/dts/rockchip/Makefile | 1 + > > > .../rk3399-rock-4c-plus-mipi-dsi.dtso | 69 +++++++++++++++++= ++ > > > 2 files changed, 70 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus-= mipi-dsi.dtso > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/= dts/rockchip/Makefile > > > index 1ebbb3e9c2f9..3a4c4cd769eb 100644 > > > --- a/arch/arm64/boot/dts/rockchip/Makefile > > > +++ b/arch/arm64/boot/dts/rockchip/Makefile > > > @@ -58,6 +58,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-roc-pc.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-roc-pc-mezzanine.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-roc-pc-plus.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-rock-4c-plus.dtb > > > +dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-rock-4c-plus-mipi-dsi.dtbo > > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-rock-4se.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-rock-pi-4a.dtb > > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-rock-pi-4a-plus.dtb > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus-mipi-ds= i.dtso b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus-mipi-dsi.dtso > > > new file mode 100644 > > > index 000000000000..271717040b6c > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus-mipi-dsi.dtso > > > @@ -0,0 +1,69 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (c) 2023 Radxa Computer Co., Ltd. > > > + * Copyright (c) 2023 Edgeble AI Technologies Pvt. Ltd. > > > + * > > > + * DT-overlay for Radxa ROCK 4C+ DSI Connector. > > > + */ > > > + > > > +/dts-v1/; > > > +/plugin/; > > > + > > > +#include > > > +#include > > > + > > > +&{/} { > > > + backlight: backlight { > > > + compatible =3D "pwm-backlight"; > > > + pwms =3D <&pwm2 0 25000 0>; > > > + }; > > > +}; > > > + > > > +&mipi_dsi { > > > + clock-master; > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + status =3D "okay"; > > > + > > > + ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + mipi_out: port@1 { > > > + reg =3D <1>; > > > + > > > + mipi_out_panel: endpoint { > > > + remote-endpoint =3D <&mipi_in_panel>; > > > + }; > > > + }; > > > + }; > > > + > > > + panel: panel@0 { > > > + /* different resolution panels are used, compatibles ar= e in DTO */ > > > > then I guess, the panel node should get a disabled here (and the mipi_d= si > > should stay disabled at this point) and both should get enabled in the = final > > dtbo where the compatible lives? >=20 > Do you mean dsi also needs to be disabled here and enabled in dtbo? if > so why? if panel disabled then dsi won't probe even if it enabled. I'm not sure how dtbo's are loaded nowadays, but if by some form of accident only this dtbo gets loaded without a panel compatible you've essentially broken the whole display output, as the dsi will defer indefinitly. Also, in more general thinking, the savings in terms of node duplication is quite minimal with this setup. Can't you just have the tiny dsi+backlight nodes in each panel dtbo? Thanks Heiko